Re: [PR] [SPARK-44426][SQL] Add support for ExistenceJoin to AQE [spark]

["vanekjar (via GitHub)" <gi...@apache.org>]

vanekjar commented on PR #57934:
URL: https://github.com/apache/spark/pull/57934#issuecomment-5798485107

   Superseded by #58569 ([SPARK-59294](https://issues.apache.org/jira/browse/SPARK-59294)), which landed this change by a different route: the join-type predicate now lives on `ShuffledJoin` as `canDuplicateRightSide`, whose `LeftExistence(_)` case covers `ExistenceJoin`, and `OptimizeSkewedJoin` gates left-side splitting on it. That PR also extended the SPARK-29544 skew join test with an existence join case for both `SHUFFLE_MERGE` and `SHUFFLE_HASH`, asserting the skewed left side is split and the right side left untouched -- the same property this PR's test checked.
   
   Nothing left to land here, so closing. Thanks @uros-b for the review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org