You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/04 05:04:22 UTC

[GitHub] [pulsar] zhaoyajun2009 opened a new pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

zhaoyajun2009 opened a new pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555


   **Motivation**
   Optimize the installation steps of the pulsar library of the Go client
   
   **Modifications**
   "
   ### Install go package
   
   You can install the `pulsar` library locally using `go get` download to local or downloading online.  
   
   Download to local:
   
   ```bash
   $ go get -u "github.com/apache/pulsar-client-go/pulsar"
   ```
   If you can't download, please try it by configure [CDN accelerated proxy]( https://learnku.com/go/wikis/38122).
   
   Once installed locally, you can import it into your project:
   
   ```go
   import "github.com/apache/pulsar-client-go/pulsar"
   ```
   
   Online download(for example):
   
   ```bash
   $ mkdir test_dir && cd test_dir 
   ```
   Write a sample script in 'test_dir' directory , such as ‘test_example.go’,and write ‘package main’ at the beginning of the file.
   
   ```bash
   $ go mod init test_dir 
   $ go mod tidy && go mod download
   $ go build test_example.go
   $ ./test_example
   ```
   "
   
   **### Documentation**
     
   - [x] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet commented on a change in pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
freeznet commented on a change in pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555#discussion_r820449615



##########
File path: site2/docs/client-libraries-go.md
##########
@@ -16,18 +16,35 @@ You can use Pulsar [Go client](https://github.com/apache/pulsar-client-go) to cr
 
 ### Install go package
 
-You can install the `pulsar` library locally using `go get`.  
+You can install the `pulsar` library locally using `go get` download to local or downloading online.  

Review comment:
       ```suggestion
   You can get the `pulsar` library by using `go get` or use it with `go module`.  
   ```

##########
File path: site2/docs/client-libraries-go.md
##########
@@ -16,18 +16,35 @@ You can use Pulsar [Go client](https://github.com/apache/pulsar-client-go) to cr
 
 ### Install go package
 
-You can install the `pulsar` library locally using `go get`.  
+You can install the `pulsar` library locally using `go get` download to local or downloading online.  
+
+Download to local:
 
 ```bash
 $ go get -u "github.com/apache/pulsar-client-go/pulsar"
 ```
+If you can't download, please try it by configure [CDN accelerated proxy]( https://learnku.com/go/wikis/38122).

Review comment:
       this should only applied to China users due the network issue, so i dont think it is proper to put it here.

##########
File path: site2/docs/client-libraries-go.md
##########
@@ -16,18 +16,35 @@ You can use Pulsar [Go client](https://github.com/apache/pulsar-client-go) to cr
 
 ### Install go package
 
-You can install the `pulsar` library locally using `go get`.  
+You can install the `pulsar` library locally using `go get` download to local or downloading online.  
+
+Download to local:
 
 ```bash
 $ go get -u "github.com/apache/pulsar-client-go/pulsar"
 ```
+If you can't download, please try it by configure [CDN accelerated proxy]( https://learnku.com/go/wikis/38122).
 
 Once installed locally, you can import it into your project:
 
 ```go
 import "github.com/apache/pulsar-client-go/pulsar"
 ```
 
+Online download(for example):

Review comment:
       ```suggestion
   Use with go module:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555#issuecomment-1060106701


   @wolfstudy can you review this PR from the technical perspective? Then writers can review it from the technical writing perspective, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaoyajun2009 commented on a change in pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
zhaoyajun2009 commented on a change in pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555#discussion_r821801915



##########
File path: site2/docs/client-libraries-go.md
##########
@@ -16,7 +16,9 @@ You can use Pulsar [Go client](https://github.com/apache/pulsar-client-go) to cr
 
 ### Install go package
 
-You can install the `pulsar` library locally using `go get`.  
+You can get the `pulsar` library by using `go get` or use it with `go module`.  
+
+Download to local:

Review comment:
       Download library of Go client to your local environment:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaoyajun2009 commented on pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
zhaoyajun2009 commented on pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555#issuecomment-1060199907


   @freeznet can you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555#discussion_r821475170



##########
File path: site2/docs/client-libraries-go.md
##########
@@ -16,7 +16,9 @@ You can use Pulsar [Go client](https://github.com/apache/pulsar-client-go) to cr
 
 ### Install go package
 
-You can install the `pulsar` library locally using `go get`.  
+You can get the `pulsar` library by using `go get` or use it with `go module`.  
+
+Download to local:

Review comment:
       ```suggestion
   Download Go client to your local environment:
   ```
   
   

##########
File path: site2/docs/client-libraries-go.md
##########
@@ -28,6 +30,20 @@ Once installed locally, you can import it into your project:
 import "github.com/apache/pulsar-client-go/pulsar"
 ```
 
+Use with go module:
+
+```bash
+$ mkdir test_dir && cd test_dir 
+```
+Write a sample script in 'test_dir' directory , such as ‘test_example.go’,and write ‘package main’ at the beginning of the file.

Review comment:
       ```suggestion
   Write a sample script in the `test_dir` directory (such as `test_example.go`) and write `package main` at the beginning of the file.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14555: [doc]Optimize the installation steps of the pulsar library of the Go client

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14555:
URL: https://github.com/apache/pulsar/pull/14555


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org