[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #296: Code improvements to restrict scoped property lookup to only terms.

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #296: Code improvements to restrict scoped property lookup to only terms.
URL: https://github.com/apache/incubator-daffodil/pull/296#discussion_r352610703
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
 ##########
 @@ -260,12 +261,7 @@ abstract class SequenceGroupTermBase(
 trait SequenceDefMixin
   extends AnnotatedSchemaComponent
   with GroupDefLike
-  with ResolvesProperties //
-  // Technically, this is not a term, so shouldn't resolve scoped properties
-  // and doesn't take into account combining ref with def properties.
-  // But we need to get one local property: dfdl:hiddenGroupRef.
-  // So we mixin ResolvesProperties, but shouldn't use it except to obtain dfdl:hiddenGroupRef.
-  {
+  with FindPropertyMixin {
 
 Review comment:
   Should this be ResolvesLocalProperties for dfdl:hiddenGroupRef instead of FindPropertyMixin?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services