You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/07/18 21:42:00 UTC
[jira] [Commented] (CASSANDRA-17649) Fix flaky tests in TopPartitionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568222#comment-17568222 ]
Ekaterina Dimitrova commented on CASSANDRA-17649:
-------------------------------------------------
This seems to be a test issue.
Running the test class In a loop with only incremental repair was [always passing|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=basic-range-tombstone&filter=all].
The moment we run it parameterized, incremental and preview repairs seem to crash. Looking into the repair method in the test class, we see the nodetool command was successfully triggered but we don't check that the repair has been completed.
I added some additional checks and the test seems not to be flaky anymore.
[~marcuse], do you mind to review the patch as the original author of this test? Or maybe [~dcapwell] ?
||Patch||CI||
|[4.1|https://github.com/ekaterinadimitrova2/cassandra/commit/7dc15ed096a676355cf841ca98eea01ca9a34a2b]|CircleCI test in a loop: [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1790/workflows/39d41ffb-57c8-48c4-99fe-f4753ca3ef3b], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1790/workflows/ab9c462c-cd83-4323-9e52-4c6caf64d5e4]|
|[trunk|https://github.com/apache/cassandra/commit/29b99e158977693c243490bb45bcbc2a39cecd9a]|CircleCI test in a loop: [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1791/workflows/604773ab-58ea-41dc-ae11-937354a054b6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1791/workflows/d7acf107-4497-4787-ac4f-352f4bf44ff1]|
> Fix flaky tests in TopPartitionsTest
> ------------------------------------
>
> Key: CASSANDRA-17649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17649
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x
>
>
> While working on other tickets we noticed a few tests from TopPartitionTest are flaky on 4.1.
> Example run with the CircleCI multiplexer: [https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=flaky_top_partitions_test_4.1&filter=all]
> I haven't seen those in Jenkins though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org