You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tajo.apache.org by "JaeHwa Jung (JIRA)" <ji...@apache.org> on 2013/12/16 08:10:07 UTC

[jira] [Commented] (TAJO-419) Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor

    [ https://issues.apache.org/jira/browse/TAJO-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848880#comment-13848880 ] 

JaeHwa Jung commented on TAJO-419:
----------------------------------

+1.
'mvn clean install' finished successfully. 

Great work!
It looks like it helps contributors implement rewrite rules. :)


> Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor
> --------------------------------------------------------------------
>
>                 Key: TAJO-419
>                 URL: https://issues.apache.org/jira/browse/TAJO-419
>             Project: Tajo
>          Issue Type: Improvement
>          Components: parser, planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-419.patch
>
>
> This patch primarily adds all missing operator types' visitor methods of AlgebraVisitor and implements concrete methods in BaseAlgebraVisitor. Currently, BaseAlgebraVisitor may cause incorrect PlanningException because BaseAlgebraVisitor does not handle all operator types. This patch eliminates this potential bug.
> In addition, this patch contains two refactors in order to eliminate duplicate names:
>  * Rename tajo.algebra.DataType to DataTypeExpr
>  * Rename tajo.algebra.Target to TargetExpr



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)