You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2024/05/19 19:18:19 UTC
[PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
snuyanzin opened a new pull request, #3793:
URL: https://github.com/apache/calcite/pull/3793
The PR is based on https://github.com/apache/calcite/pull/3591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2131184111
>I'm sure you've tested it all locally
yep, exactly, however the main test is ci since locally I have only one OS and on ci there are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #3793:
URL: https://github.com/apache/calcite/pull/3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2131171842
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [33.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2131231175
I will merge tomorrow if there is no objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #3793:
URL: https://github.com/apache/calcite/pull/3793#discussion_r1606094164
##########
build.gradle.kts:
##########
@@ -792,6 +808,9 @@ allprojects {
inputs.property("java.vm.version", System.getProperty("java.vm.version"))
options.encoding = "UTF-8"
options.compilerArgs.add("-Xlint:deprecation")
+ // JDK 1.8 is deprecated https://bugs.openjdk.org/browse/JDK-8173605
+ // and now it requires -Xlint:-options to mute warnings about its deprecation
+ options.compilerArgs.add("-Xlint:-options")
Review Comment:
Approach similar to one done within openJDK https://github.com/openjdk/jdk/pull/10135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2119343581
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [33.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2131184867
I rebased the PR since gradle8 support was merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2132217482
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3793&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3793&resolved=false&sinceLeakPeriod=true)
 [33.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3793&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3793)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org