You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by "tartarus (Jira)" <ji...@apache.org> on 2020/06/28 08:21:00 UTC

[jira] [Created] (HDDS-3887) Remove redundant code for HealthyPipelineSafeModeRule

tartarus created HDDS-3887:
------------------------------

             Summary: Remove redundant code for HealthyPipelineSafeModeRule
                 Key: HDDS-3887
                 URL: https://issues.apache.org/jira/browse/HDDS-3887
             Project: Hadoop Distributed Data Store
          Issue Type: Improvement
          Components: SCM
    Affects Versions: 0.5.0
            Reporter: tartarus
            Assignee: tartarus


HealthyPipelineSafeModeRule#validate
{code:java}
protected boolean validate() {
  if (currentHealthyPipelineCount >= healthyPipelineThresholdCount) {
    return true;
  }
  return false;
}{code}
this method is fat，I think direct return is ok. like this

 
{code:java}
return currentHealthyPipelineCount >= healthyPipelineThresholdCount;
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org