You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/08 11:55:26 UTC

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1210: [Feature][CI] Automatically generate LICENSE

asdf2014 commented on pull request #1210:
URL: https://github.com/apache/incubator-seatunnel/pull/1210#issuecomment-1032527010


   Hi @CalvinKirs, thanks for your comment. Yes, the license-maven-plugin plugin can exclude unknown license, but I think we shouldn't ignore them, we should clean up our dependencies tree to avoid unknown licenses.
   
   > This may be more suitable as a check, but it is not suitable for CI to automatically add.
   
   Sure, we can disable this generator by default, and add a check for the LICENSE. Or, we can automatically modify the LICENSE for each PRs that have changed the dependency tree, after the PR created. What do you think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org