[GitHub] [drill] vvysotskyi commented on issue #1849: DRILL-7362: COUNT(*) on JSON with outer list results in JsonParse error

[GitBox <gi...@apache.org>]

vvysotskyi commented on issue #1849: DRILL-7362: COUNT(*) on JSON with outer list results in JsonParse error
URL: https://github.com/apache/drill/pull/1849#issuecomment-526189826
 
 
   @oleg-zinovev, thanks for fixing this issue! 
   Could you please reuse code from `JsonReader` class - for example, move required code to the parent class and extend classes which share the code. Also, you have added some additional parameters to the constructor, which may be omitted since they always have the same value.
   Please update the test case to check the returned result.
   
   One more thing - please assign Jira to yourself and mark it as "In progress" when you are starting working on it, and change its state to "Reviewable" when PR is opened (Thanks to @arina-ielchiieva  for doing these things for you).
   
   For more details, connected with the development process, please refer to https://drill.apache.org/docs/apache-drill-contribution-guidelines/.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services