You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Joe Fernandez (JIRA)" <ji...@apache.org> on 2007/10/15 22:28:24 UTC
[jira] Created: (AMQ-1465) Regression with networkConnector 'name'
attribute
Regression with networkConnector 'name' attribute
-------------------------------------------------
Key: AMQ-1465
URL: https://issues.apache.org/activemq/browse/AMQ-1465
Project: ActiveMQ
Issue Type: Bug
Components: Connector
Environment: ActiveMQ 5.0
Reporter: Joe Fernandez
Priority: Minor
Fix For: 5.0.0
On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-1465) Regression with networkConnector 'name'
attribute
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated AMQ-1465:
-------------------------------
Fix Version/s: (was: 5.0.0)
5.1.0
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1465) Regression with networkConnector
'name' attribute
Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41005#action_41005 ]
Trevor Pounds commented on AMQ-1465:
------------------------------------
I've noticed this as well during my testing. I modeled this behavior when i submitted patches to improve the LdapNetworkConnector support. If no one takes this task on I will try to provide a patch for this at some point soon...
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-1465) Regression with networkConnector 'name'
attribute
Posted by "Rob Davies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Davies resolved AMQ-1465.
-----------------------------
Resolution: Fixed
Patch applied in SVN revision 646803
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: patch.r61674.diff, patchfile.txt
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-1465) Regression with networkConnector 'name'
attribute
Posted by "Rob Davies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Davies reassigned AMQ-1465:
-------------------------------
Assignee: Rob Davies
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.0.0
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1465) Regression with networkConnector
'name' attribute
Posted by "Joe Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41025#action_41025 ]
Joe Fernandez commented on AMQ-1465:
------------------------------------
wrt the original implementation; if the user had multiple network connectors w/out a 'name' attribute, the broker would throw an exception. This was because you'd end up having multiple network connectors with the same name (i.e., "localhost"). My patch addressed this by assigning a unique name to each network connection having a 'null' name (i.e., no name specified). - Joe
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: patch.r61674.diff, patchfile.txt
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1465) Regression with networkConnector
'name' attribute
Posted by "Joe Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41008#action_41008 ]
Joe Fernandez commented on AMQ-1465:
------------------------------------
There are some trivial improvements that I'd like to add to this area and it looks like I'll have some free time to start on this today. I'll also take a crack at this issue.
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1465) Regression with networkConnector
'name' attribute
Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41026#action_41026 ]
Trevor Pounds commented on AMQ-1465:
------------------------------------
This is still the case for specific NetworkConnector impl (i.e. Discovery, Multicast, LDAP). However if there is a new connector in the future that does not override the default getName impl then it will default to "localhost."
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: patch.r61674.diff, patchfile.txt
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-1465) Regression with networkConnector 'name'
attribute
Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trevor Pounds updated AMQ-1465:
-------------------------------
Attachment: patch.r61674.diff
I've attached an updated version of the patch. I've made 2 notable changes to the one submitted by Joe:
- changed base getName method to set and return "localhost" as the default if it has not been previously set
- LdapNetworkConnector getName method to return a better default representation
> Regression with networkConnector 'name' attribute
> -------------------------------------------------
>
> Key: AMQ-1465
> URL: https://issues.apache.org/activemq/browse/AMQ-1465
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Environment: ActiveMQ 5.0
> Reporter: Joe Fernandez
> Assignee: Rob Davies
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: patch.r61674.diff, patchfile.txt
>
>
> On 4.1.1, the value assigned to the networkConnector's 'name' attribute shows up nicely on the jconsole. However, there appears to be a regression with 5.0, because the name no longer shows up on the jconsole. With 5.0, you instead see the String representation of an instance of the SimpleDiscoveryAgent class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.