You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gabor Kaszab (Code Review)" <ge...@cloudera.org> on 2019/08/07 09:25:34 UTC
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14027
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
IMPALA-8600: Fix test_acid_compaction
Apparently Hive doesn't update the writeIds on a transactional table
after compaction. This breaks an assumption made in the REFRESH table
logic that only does an actual refresh when the HMS writeId is
different than the one cached locally. As a result the non-partitioned
ACID tables aren't refreshed when a REFRESH table is invoked in Impala
right after a major compaction.
Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 9 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14027/1
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:34:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4167/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:06:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 14:50:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:42:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
IMPALA-8600: Fix test_acid_compaction
Apparently Hive doesn't update the writeIds on a transactional table
after compaction. This breaks an assumption made in the REFRESH table
logic that only does an actual refresh when the HMS writeId is
different than the one cached locally. As a result the non-partitioned
ACID tables aren't refreshed when a REFRESH table is invoked in Impala
right after a major compaction.
Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Reviewed-on: http://gerrit.cloudera.org:8080/14027
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 9 insertions(+), 29 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 )
Change subject: IMPALA-8600: Fix test_acid_compaction
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4749/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b79f8864b31e18eca818032ad5a9af954913f6
Gerrit-Change-Number: 14027
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:42:30 +0000
Gerrit-HasComments: No