[GitHub] [superset] zhaoyongjie commented on a change in pull request #17837: refactor(monorepo): update lock file

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #17837:
URL: https://github.com/apache/superset/pull/17837#discussion_r772843317



##########
File path: superset-frontend/scripts/lernaVersion.sh
##########
@@ -53,11 +53,7 @@ fi
 
 # Get the current tag version
 tag=v$(node -e "process.stdout.write(require('./lerna.json').version)");
-message="chore: publish $tag"
-
-# Update the lock file here
-rm "$rootDir/package-lock.json"

Review comment:
       no need to update lock file when use file dependencies in `packages.json`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org