You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/06/25 16:37:52 UTC
[GitHub] trafficserver pull request #742: TS-4589: Coalesce CPP API examples build.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/742
TS-4589: Coalesce CPP API examples build.
The CPP API examples all have trivial, identical makefiles. Coalesce
these like we did to the TSAPI examples to parallelize the build,
remove duplication and support the --enable-example-plugins build
option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4589
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #742
----
commit e9b68c3ac377528eaafb2310b4d97d2e0676c9b0
Author: James Peach <jp...@apache.org>
Date: 2016-06-25T16:36:11Z
TS-4589: Coalesce CPP API examples build.
The CPP API examples all have trivial, identical makefiles. Coalesce
these like we did to the TSAPI examples to parallelize the build,
remove duplication and support the --enable-example-plugins build
option.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #742: TS-4589: Coalesce CPP API examples build.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/742
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #742: TS-4589: Coalesce CPP API examples build.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/742
One of the motivations for this is to reduce the number of sub-makefiles so that adding a ``tidy`` target for ``clang-tidy`` is more tractable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #742: TS-4589: Coalesce CPP API examples build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/742
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/238/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #742: TS-4589: Coalesce CPP API examples build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/742
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/344/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #742: TS-4589: Coalesce CPP API examples build.
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/742
Lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #742: TS-4589: Coalesce CPP API examples build.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---