You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 16:39:24 UTC

[jira] [Created] (LUCENE-3950) load rat via ivy for rat-sources task

load rat via ivy for rat-sources task
-------------------------------------

                 Key: LUCENE-3950
                 URL: https://issues.apache.org/jira/browse/LUCENE-3950
             Project: Lucene - Java
          Issue Type: Improvement
          Components: general/build
            Reporter: Robert Muir


we now fail the build on rat problems (LUCENE-1866),
so we should make it easy to run rat-sources for people
to test locally (it takes like 3 seconds total for the whole trunk)

Also this is safer than putting rat in your ~/.ant/lib because that 
adds some classes from commons to your ant classpath (which we currently
wrongly use in compile).


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3950) load rat via ivy for rat-sources task

Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246323#comment-13246323 ] 

Dawid Weiss commented on LUCENE-3950:
-------------------------------------

+1. I think this, license checks, CRLFs and other non-code things should be part of an integration test target. So that if you want to actually test code you can apply a filter and have a quick turnaround and for full integration tests you can fire them before the commit etc.
                
> load rat via ivy for rat-sources task
> -------------------------------------
>
>                 Key: LUCENE-3950
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3950
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Robert Muir
>
> we now fail the build on rat problems (LUCENE-1866),
> so we should make it easy to run rat-sources for people
> to test locally (it takes like 3 seconds total for the whole trunk)
> Also this is safer than putting rat in your ~/.ant/lib because that 
> adds some classes from commons to your ant classpath (which we currently
> wrongly use in compile).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3950) load rat via ivy for rat-sources task

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246393#comment-13246393 ] 

Robert Muir commented on LUCENE-3950:
-------------------------------------

{quote}
So that if you want to actually test code you can apply a filter and have a quick turnaround and for full integration tests you can fire them before the commit etc.
{quote}

For this we should probably add a 'quiet' mode too for that purpose. rat-sources serves a double-duty, 
it also creates hugeish output for human review (since really for releasing thats required, its heuristical).

But we fail on "unknown" licenses which is safe, and detects the common case of 'forgot license header'.

                
> load rat via ivy for rat-sources task
> -------------------------------------
>
>                 Key: LUCENE-3950
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3950
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Robert Muir
>
> we now fail the build on rat problems (LUCENE-1866),
> so we should make it easy to run rat-sources for people
> to test locally (it takes like 3 seconds total for the whole trunk)
> Also this is safer than putting rat in your ~/.ant/lib because that 
> adds some classes from commons to your ant classpath (which we currently
> wrongly use in compile).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org