You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/02 02:22:03 UTC

[GitHub] [flink] m8719-github opened a new pull request, #20936: [FLINK-13703][flink-formats/flink-avro] AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

m8719-github opened a new pull request, #20936:
URL: https://github.com/apache/flink/pull/20936

   ## What is the purpose of the change
   
   This change will allow Flink to handle avro-compiled classes with following settings:
   - `gettersReturnOptional = true`
   - `optionalGettersForNullableFieldsOnly = true`
   
   more info here: [FLINK-13703](https://issues.apache.org/jira/browse/FLINK-13703)
   
   
   ## Change log
     - *Modified isValidPojoField logic to handle Optional getters*
     - *Added flink-core tests*
     - *Added flink-avro tests*
   
   
   ## Verifying this change
   
     - **flink-core tests**:
       - added:
         - `PojoTypeExtractionTest#testPojoWithOptionalGetters`
         - `TypeExtractorTest#testPojoWithOptionalGetters`
       - extended:
         - `PojoTypeInfoTest`
    - **flink-avro tests**:
      - added:
        - `AvroStreamingFileSinkITCase#testWriteAvroSpecificWithOptionalGetters`
        - `RegistryAvroDeserializationSchemaTest#testSpecificRecordReadMoreFieldsThanWereWrittenOptionalEmpty`
        - `AvroTypeExtractionTest#testSerializeWithAvroOptionalGetters`
        - `AvroTypeExtractionTest#testKeySelectionOptional`
        - `AvroTypeExtractionTest#testWithAvroGenericSerOptional`
        - `AvroTypeExtractionTest#testWithKryoGenericSerOptional`
      - extended:
        - `AvroOutputFormatTest#testSerialization`
        - `AvroTypeExtractionTest#testSimpleAvroRead`
        - `AvroTypeInfoTest#AvroTypeInfoTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature: **no**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] patricklucas commented on pull request #20936: [FLINK-13703][flink-formats/flink-avro] AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

Posted by "patricklucas (via GitHub)" <gi...@apache.org>.
patricklucas commented on PR #20936:
URL: https://github.com/apache/flink/pull/20936#issuecomment-1578821997

   @rmetzger friendly ping since you offered to review ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] m8719-github commented on pull request #20936: [FLINK-13703][flink-formats/flink-avro] AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

Posted by GitBox <gi...@apache.org>.
m8719-github commented on PR #20936:
URL: https://github.com/apache/flink/pull/20936#issuecomment-1265589920

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20936: [FLINK-13703][flink-formats/flink-avro] AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20936:
URL: https://github.com/apache/flink/pull/20936#issuecomment-1264531349

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4ea721f7b45426872e262982f3eece27d3e173d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4ea721f7b45426872e262982f3eece27d3e173d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4ea721f7b45426872e262982f3eece27d3e173d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org