You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/04 21:00:05 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request #2221: Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

acassis opened a new pull request #2221:
URL: https://github.com/apache/incubator-nuttx/pull/2221


   ## Summary
   Make the final CP: nuttx.bin message easy to spot to confirm that compilation finished correct.
   ## Impact
   User will be be able to see the generated binaries easily. Please refer to #2219 
   ## Testing
   esp32-core:nsh
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2221: Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2221:
URL: https://github.com/apache/incubator-nuttx/pull/2221


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #2221: Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2221:
URL: https://github.com/apache/incubator-nuttx/pull/2221#issuecomment-721978393


   Please update the post build macros as well. I think there are two boards with that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #2221: Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2221:
URL: https://github.com/apache/incubator-nuttx/pull/2221#issuecomment-722042405


   Yep those are the two so I guess this is already covered. Thanks for checking. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #2221: Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2221:
URL: https://github.com/apache/incubator-nuttx/pull/2221#issuecomment-722033794


   > Please update the post build macros as well. I think there are two boards with that.
   
   Hi Brennan, did you mean these two:
   boards/xtensa/esp32/esp32-core/scripts/Config.mk
   tools/cxd56/Config.mk
   
   They are already with $(Q) on it. I did a "git grep manifest" to spot other files, but there is no other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org