[GitHub] [superset] yougyoung94 commented on a change in pull request #17112: fix: auto refresh interval won't be updated

[GitBox <gi...@apache.org>]

yougyoung94 commented on a change in pull request #17112:
URL: https://github.com/apache/superset/pull/17112#discussion_r729857187



##########
File path: superset-frontend/src/dashboard/containers/DashboardPage.tsx
##########
@@ -57,16 +57,20 @@ const DashboardPage: FC = () => {
   const { result: datasets, error: datasetsApiError } = useDashboardDatasets(
     idOrSlug,
   );
-  const isDashboardHydrated = useRef(false);
 
   const error = dashboardApiError || chartsApiError;
   const readyToRender = Boolean(dashboard && charts);
   const { dashboard_title, css } = dashboard || {};
 
-  if (readyToRender && !isDashboardHydrated.current) {
-    isDashboardHydrated.current = true;
-    dispatch(hydrateDashboard(dashboard, charts));
-  }
+  useEffect(() => {

Review comment:
       I changed this part referring to [this part](https://github.com/apache/superset/blob/286ba5d37d4e240d01bbefd2307a816829cf512d/superset-frontend/src/dashboard/containers/DashboardPage.tsx#L61-L66)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org