You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/18 10:31:18 UTC

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
-----------------------------------------------------------

(Updated 四月 18, 2016, 8:31 a.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-4886
    https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
-------

Enabled mesos containerizer force_pull_image for docker.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96 

Diff: https://reviews.apache.org/r/44838/diff/


Testing
-------

make
make check

It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.


Thanks,

Guangya Liu