[jira] [Closed] (IO-447) Possible NPE in FileSystemUtils.freeSpaceWindows; FilenameUtils.normalize can return null

["Gary D. Gregory (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory closed IO-447.
------------------------------
    Resolution: Fixed

As some point in the past, we added a check for a null.

> Possible NPE in FileSystemUtils.freeSpaceWindows; FilenameUtils.normalize can return null
> -----------------------------------------------------------------------------------------
>
>                 Key: IO-447
>                 URL: https://issues.apache.org/jira/browse/IO-447
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Major
>
> There is a possible NPE in FileSystemUtils.freeSpaceWindows.
> FilenameUtils.normalize can return null so the path.length() will NPE
> For example, ".." returns null.
> I'm not entirely sure why the path needs to be normalised, apart from converting / to \. Even that seems a bit dubious - why should the user want to return the freespace for a Unix-style path on a Windows system?
> And if it does need to be normalised, why not use the File class, which handles / to \ conversion transparently?
> A short term fix would be to return IAE for paths that normalise to null.
> However that would not allow the use of paths such as ".." - though at least that would not cause NPE.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)