You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by tae-jun <gi...@git.apache.org> on 2016/11/07 12:22:39 UTC

[GitHub] zeppelin pull request #1609: [ZEPPELIN-1628] Enable renaming note from the m...

GitHub user tae-jun opened a pull request:

https://github.com/apache/zeppelin/pull/1609

[ZEPPELIN-1628] Enable renaming note from the main page

### What is this PR for?
Now users can rename a note from the main page! This new feature will improve UX.

I divided [ZEPPELIN-1598](https://issues.apache.org/jira/browse/ZEPPELIN-1598) into sub-tasks since renaming folder gonna be huge. I will open PR for [ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629) after merging this PR.

By the way, I have a question! Does a `writer` can rename a note? Currently, only an owner can rename a note.

### What type of PR is it?
[Feature]

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1628

### Screenshots (if appropriate)
![rename_note](https://cloud.githubusercontent.com/assets/8201019/20057051/a16b221c-a52c-11e6-900e-f88031ff1246.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1628

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1609

----

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by tae-jun <gi...@git.apache.org>.

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    @AhyoungRyu Thanks for the review! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by tae-jun <gi...@git.apache.org>.

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    @AhyoungRyu I fixed it! It took some time to improve UX \U0001f604
    
    Now when an input text is not valid, users can't click the button and the modal shows error message
    
    ![rename_note_validation](https://cloud.githubusercontent.com/assets/8201019/20105201/154ae680-a614-11e6-94d1-7464a8bce7f9.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    @tae-jun Awesome!  
    I tested this patch but seems it needs to prevent blank title when we rename the note. Please see the below gif img. 
    ![edit_notename](https://cloud.githubusercontent.com/assets/10060731/20060790/31c6dc9e-a540-11e6-8541-0b6db19252eb.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by tae-jun <gi...@git.apache.org>.

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    CI is green!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    @tae-jun Thanks for your prompt response. The latest change looks good to me \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by tae-jun <gi...@git.apache.org>.

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    @AhyoungRyu Thanks for the quick review! You are right! I will fix it. Please wait \U0001f604


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1609: [ZEPPELIN-1628] Enable renaming note from the m...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1609


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1609
  
    Thanks @tae-jun for useful feature contribution.
    LGTM and merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---