You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "szaszm (via GitHub)" <gi...@apache.org> on 2025/07/15 12:11:52 UTC

Re: [PR] MINIFICPP-2576 Improve the performance of ConsumeWindowsEventLog [nifi-minifi-cpp]

szaszm commented on code in PR #1985:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1985#discussion_r2207310764


##########
extensions/windows-event-log/wel/WindowsEventLog.h:
##########
@@ -58,11 +58,39 @@ enum METADATA {
   COMPUTER,
   UNKNOWN
 };
+// this is a continuous enum, so we can rely on the array

Review Comment:
   what array? This comment seems to apply to the enum, so I'd put it above that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org