You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Dongqi Xue <do...@gmail.com> on 2017/10/02 23:48:35 UTC
Review Request 62741: [HELIX-670] Fix typo in Javadoc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62741/
-----------------------------------------------------------
Review request for helix.
Bugs: HELIX-670
Repository: helix-git
Description
-------
commit 9c189f75266ed8ac3820f8cf74a5d9a6ac688814
Author: Dongqi Xue <do...@gmail.com>
Date: Mon Oct 2 16:34:49 2017 -0700
[HELIX-670] Fix typo in Javadoc
:100644 100644 32510c0... 28891b2... M helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
:100644 100644 6ff76e9... b569849... M helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 32510c0
helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java 6ff76e9
Diff: https://reviews.apache.org/r/62741/diff/1/
Testing
-------
Thanks,
Dongqi Xue
Re: Review Request 62741: [HELIX-670] Fix typo in Javadoc
Posted by Junkai Xue <ju...@gmail.com>.
> On Oct. 3, 2017, 10:56 p.m., Junkai Xue wrote:
> > Ship It!
Please create a pull request for this.
- Junkai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62741/#review187020
-----------------------------------------------------------
On Oct. 2, 2017, 11:48 p.m., Dongqi Xue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62741/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:48 p.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-670
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9c189f75266ed8ac3820f8cf74a5d9a6ac688814
> Author: Dongqi Xue <do...@gmail.com>
> Date: Mon Oct 2 16:34:49 2017 -0700
>
> [HELIX-670] Fix typo in Javadoc
>
> :100644 100644 32510c0... 28891b2... M helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
> :100644 100644 6ff76e9... b569849... M helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 32510c0
> helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java 6ff76e9
>
>
> Diff: https://reviews.apache.org/r/62741/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dongqi Xue
>
>
Re: Review Request 62741: [HELIX-670] Fix typo in Javadoc
Posted by Dongqi Xue <do...@gmail.com>.
> On Oct. 3, 2017, 10:56 p.m., Junkai Xue wrote:
> > Ship It!
>
> Junkai Xue wrote:
> Please create a pull request for this.
Here is the pull request: https://github.com/apache/helix/pull/112
- Dongqi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62741/#review187020
-----------------------------------------------------------
On Oct. 2, 2017, 11:48 p.m., Dongqi Xue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62741/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:48 p.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-670
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9c189f75266ed8ac3820f8cf74a5d9a6ac688814
> Author: Dongqi Xue <do...@gmail.com>
> Date: Mon Oct 2 16:34:49 2017 -0700
>
> [HELIX-670] Fix typo in Javadoc
>
> :100644 100644 32510c0... 28891b2... M helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
> :100644 100644 6ff76e9... b569849... M helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 32510c0
> helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java 6ff76e9
>
>
> Diff: https://reviews.apache.org/r/62741/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dongqi Xue
>
>
Re: Review Request 62741: [HELIX-670] Fix typo in Javadoc
Posted by Junkai Xue <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62741/#review187020
-----------------------------------------------------------
Ship it!
Ship It!
- Junkai Xue
On Oct. 2, 2017, 11:48 p.m., Dongqi Xue wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62741/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:48 p.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-670
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9c189f75266ed8ac3820f8cf74a5d9a6ac688814
> Author: Dongqi Xue <do...@gmail.com>
> Date: Mon Oct 2 16:34:49 2017 -0700
>
> [HELIX-670] Fix typo in Javadoc
>
> :100644 100644 32510c0... 28891b2... M helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
> :100644 100644 6ff76e9... b569849... M helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 32510c0
> helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java 6ff76e9
>
>
> Diff: https://reviews.apache.org/r/62741/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dongqi Xue
>
>