You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/09/10 01:57:13 UTC
Review Request 14044: Updated the balloon tests to test the memory threshold.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14044/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-662
https://issues.apache.org/jira/browse/MESOS-662
Repository: mesos-git
Description
-------
I've added the ability to pass arguments to the test scripts in order to verify a few different allocation / slave configurations.
Diffs
-----
src/examples/balloon_executor.cpp ad1d861aa6b5396f66e703326802926c7a99773c
src/examples/balloon_framework.cpp 53859bce4314ec23cbec66d80bc5cae4e3dec796
src/tests/balloon_framework_test.sh 8e99456548015ee92904b228b6c09355ed3388e4
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/examples_tests.cpp 28ff0f320ea76733b592a81ba8c5ef11d5332c39
src/tests/script.hpp f0c71e17d885d207cb1d84385775291196e402be
src/tests/script.cpp e72eea63bf25cd75ed1c44714b281530605c7db3
Diff: https://reviews.apache.org/r/14044/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 14044: Updated the balloon tests to test the memory
threshold.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14044/#review26416
-----------------------------------------------------------
Ship it!
src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/14044/#comment51617>
const &
src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/14044/#comment51612>
const &?
src/tests/balloon_framework_test.sh
<https://reviews.apache.org/r/14044/#comment51614>
Can we use ${} everywhere?
src/tests/balloon_framework_test.sh
<https://reviews.apache.org/r/14044/#comment51613>
+1 to using ${1}.
- Benjamin Hindman
On Sept. 9, 2013, 11:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14044/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 11:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-662
> https://issues.apache.org/jira/browse/MESOS-662
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've added the ability to pass arguments to the test scripts in order to verify a few different allocation / slave configurations.
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp ad1d861aa6b5396f66e703326802926c7a99773c
> src/examples/balloon_framework.cpp 53859bce4314ec23cbec66d80bc5cae4e3dec796
> src/tests/balloon_framework_test.sh 8e99456548015ee92904b228b6c09355ed3388e4
> src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
> src/tests/examples_tests.cpp 28ff0f320ea76733b592a81ba8c5ef11d5332c39
> src/tests/script.hpp f0c71e17d885d207cb1d84385775291196e402be
> src/tests/script.cpp e72eea63bf25cd75ed1c44714b281530605c7db3
>
> Diff: https://reviews.apache.org/r/14044/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 14044: Updated the balloon tests to test the memory
threshold.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14044/
-----------------------------------------------------------
(Updated Sept. 27, 2013, 12:50 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Reviews from benh and vinod.
Bugs: MESOS-662
https://issues.apache.org/jira/browse/MESOS-662
Repository: mesos-git
Description
-------
I've added the ability to pass arguments to the test scripts in order to verify a few different allocation / slave configurations.
Diffs (updated)
-----
src/examples/balloon_executor.cpp ad1d861
src/examples/balloon_framework.cpp 53859bc
src/tests/balloon_framework_test.sh 8e99456
src/tests/cgroups_isolator_tests.cpp 1f5ce76
src/tests/examples_tests.cpp 28ff0f3
src/tests/script.hpp f0c71e1
src/tests/script.cpp e72eea6
Diff: https://reviews.apache.org/r/14044/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 14044: Updated the balloon tests to test the memory
threshold.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14044/#review26150
-----------------------------------------------------------
Ship it!
src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/14044/#comment51056>
s/step/step and limit/
src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/14044/#comment51057>
Why not just have argv[2] contain MB?
src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/14044/#comment51058>
ditto.
src/tests/balloon_framework_test.sh
<https://reviews.apache.org/r/14044/#comment51059>
why not do ${2}MB and ${3}MB here?
src/tests/cgroups_isolator_tests.cpp
<https://reviews.apache.org/r/14044/#comment51060>
great tests!
src/tests/script.cpp
<https://reviews.apache.org/r/14044/#comment51061>
How about CHECK_LT(arguments.size(), ARG_MAX)?
- Vinod Kone
On Sept. 9, 2013, 11:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14044/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 11:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-662
> https://issues.apache.org/jira/browse/MESOS-662
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've added the ability to pass arguments to the test scripts in order to verify a few different allocation / slave configurations.
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp ad1d861aa6b5396f66e703326802926c7a99773c
> src/examples/balloon_framework.cpp 53859bce4314ec23cbec66d80bc5cae4e3dec796
> src/tests/balloon_framework_test.sh 8e99456548015ee92904b228b6c09355ed3388e4
> src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
> src/tests/examples_tests.cpp 28ff0f320ea76733b592a81ba8c5ef11d5332c39
> src/tests/script.hpp f0c71e17d885d207cb1d84385775291196e402be
> src/tests/script.cpp e72eea63bf25cd75ed1c44714b281530605c7db3
>
> Diff: https://reviews.apache.org/r/14044/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>