You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by codecleric <gi...@git.apache.org> on 2015/11/23 23:52:26 UTC
[GitHub] couchdb pull request: Fix version checking for python pygments.
GitHub user codecleric opened a pull request:
https://github.com/apache/couchdb/pull/371
Fix version checking for python pygments.
Current method only works for version numbers with only one decimal point. This version splits the version number on '.' and compares the individual components.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/codecleric/couchdb 1.6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit 22dd591856701ef44323f13912a6f16a1d98ca1a
Author: Brian Brown <br...@codecleric.com>
Date: 2015-11-23T22:40:39Z
Fix version checking for python pygments. Current method only works for versions numbers with only one decimal point
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix version checking for python pygments.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/371#issuecomment-159345935
Just new PR against different branch. No need to disturb JIRA about trivial changes.
No worries! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix version checking for python pygments.
Posted by codecleric <gi...@git.apache.org>.
Github user codecleric commented on the pull request:
https://github.com/apache/couchdb/pull/371#issuecomment-159345316
So I should open a PR in Jira against the 1.x.x branch, or just do a new pull request against the different branch?
Sorry, its my first time contributing to CouchDB ;-)
-- Brian
On November 23, 2015 5:59:18 PM MST, Alexander Shorin <no...@github.com> wrote:
>Nice found! Thanks! Could only please reopen PR against 1.x.x branch?
>It is the future for 1.7 release.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/couchdb/pull/371#issuecomment-159117686
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix version checking for python pygments.
Posted by codecleric <gi...@git.apache.org>.
Github user codecleric closed the pull request at:
https://github.com/apache/couchdb/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix version checking for python pygments.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/371#issuecomment-159117686
Nice found! Thanks! Could only please reopen PR against 1.x.x branch? It is the future for 1.7 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---