You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/01/07 00:41:09 UTC
Re: Review Request 41819: Added ContainerConfig to all isolators.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 3:41 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240
Repository: mesos
Description
-------
Added ContainerConfig to all isolators.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0
src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4
src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760
src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 3b95e195ad704f163c245175390d9a26bde7e17c
src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 09952369c72d3c6322ae7a1c73cd68226d452ad2
src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 2ddb9f4adbb879682cd39966ab974cf3fa32209c
src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee
src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 4d82c2b2f231c59cbb600869a0f2b716c1e55f5e
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp a29f9d184a0d1088577b3168a12bc8c06493a477
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8af2cecdca947e55d8d39e26d2fc3d42212f36c3
src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c3544aa313cbb185efb03bba59961cdf2b616a37
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 2e457015a0348a457581edf493877b71fab17090
src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 361ed6561bd5e2f75d026922def01f42b43d61c2
src/slave/containerizer/mesos/isolators/namespaces/pid.hpp c2d1455249618f9cd2e17dc2244b184d52b32eaf
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d65c1593b44f4b21237581147e57e441ebf3160d
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e3766c313a1bd2a838a73730c62c74c5ee8e1a4c
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 22a8428427b758bae4a0518356d7933c4110cd9f
src/slave/containerizer/mesos/isolators/posix.hpp 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c
src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8
src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d
Diff: https://reviews.apache.org/r/41819/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 41819: Added ContainerConfig to all isolators.
Posted by Gilbert Song <so...@gmail.com>.
> On Jan. 7, 2016, 4:16 p.m., Jie Yu wrote:
> >
Fixed at `41816`.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/#review113372
-----------------------------------------------------------
On Jan. 6, 2016, 3:41 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41819/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 3:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4240
> https://issues.apache.org/jira/browse/MESOS-4240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ContainerConfig to all isolators.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0
> src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 3b95e195ad704f163c245175390d9a26bde7e17c
> src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 09952369c72d3c6322ae7a1c73cd68226d452ad2
> src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 2ddb9f4adbb879682cd39966ab974cf3fa32209c
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 4d82c2b2f231c59cbb600869a0f2b716c1e55f5e
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp a29f9d184a0d1088577b3168a12bc8c06493a477
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8af2cecdca947e55d8d39e26d2fc3d42212f36c3
> src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c3544aa313cbb185efb03bba59961cdf2b616a37
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
> src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 2e457015a0348a457581edf493877b71fab17090
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 361ed6561bd5e2f75d026922def01f42b43d61c2
> src/slave/containerizer/mesos/isolators/namespaces/pid.hpp c2d1455249618f9cd2e17dc2244b184d52b32eaf
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d65c1593b44f4b21237581147e57e441ebf3160d
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e3766c313a1bd2a838a73730c62c74c5ee8e1a4c
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 22a8428427b758bae4a0518356d7933c4110cd9f
> src/slave/containerizer/mesos/isolators/posix.hpp 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c
> src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d
>
> Diff: https://reviews.apache.org/r/41819/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41819: Added ContainerConfig to all isolators.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/#review113372
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/containerizer.cpp (lines 688 - 689)
<https://reviews.apache.org/r/41819/#comment173950>
No need to pass in these two parameters anymore.
src/slave/containerizer/mesos/containerizer.cpp (lines 693 - 702)
<https://reviews.apache.org/r/41819/#comment173949>
Please move this to 'prepare'.
- Jie Yu
On Jan. 6, 2016, 11:41 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41819/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 11:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4240
> https://issues.apache.org/jira/browse/MESOS-4240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ContainerConfig to all isolators.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0
> src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 3b95e195ad704f163c245175390d9a26bde7e17c
> src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 09952369c72d3c6322ae7a1c73cd68226d452ad2
> src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 2ddb9f4adbb879682cd39966ab974cf3fa32209c
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 4d82c2b2f231c59cbb600869a0f2b716c1e55f5e
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp a29f9d184a0d1088577b3168a12bc8c06493a477
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8af2cecdca947e55d8d39e26d2fc3d42212f36c3
> src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c3544aa313cbb185efb03bba59961cdf2b616a37
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
> src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 2e457015a0348a457581edf493877b71fab17090
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 361ed6561bd5e2f75d026922def01f42b43d61c2
> src/slave/containerizer/mesos/isolators/namespaces/pid.hpp c2d1455249618f9cd2e17dc2244b184d52b32eaf
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d65c1593b44f4b21237581147e57e441ebf3160d
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e3766c313a1bd2a838a73730c62c74c5ee8e1a4c
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 22a8428427b758bae4a0518356d7933c4110cd9f
> src/slave/containerizer/mesos/isolators/posix.hpp 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c
> src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d
>
> Diff: https://reviews.apache.org/r/41819/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41819: Added ContainerConfig to all isolators.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 1:19 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240
Repository: mesos
Description
-------
Added ContainerConfig to all isolators.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0
src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4
src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760
src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 3b95e195ad704f163c245175390d9a26bde7e17c
src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 09952369c72d3c6322ae7a1c73cd68226d452ad2
src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 2ddb9f4adbb879682cd39966ab974cf3fa32209c
src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee
src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 4d82c2b2f231c59cbb600869a0f2b716c1e55f5e
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp a29f9d184a0d1088577b3168a12bc8c06493a477
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8af2cecdca947e55d8d39e26d2fc3d42212f36c3
src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c3544aa313cbb185efb03bba59961cdf2b616a37
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 4d6100e49aa1e4dcc78900a51826de0658c540d6
src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 2e457015a0348a457581edf493877b71fab17090
src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 361ed6561bd5e2f75d026922def01f42b43d61c2
src/slave/containerizer/mesos/isolators/namespaces/pid.hpp c2d1455249618f9cd2e17dc2244b184d52b32eaf
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d65c1593b44f4b21237581147e57e441ebf3160d
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e3766c313a1bd2a838a73730c62c74c5ee8e1a4c
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 22a8428427b758bae4a0518356d7933c4110cd9f
src/slave/containerizer/mesos/isolators/posix.hpp 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c
src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8
src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d
Diff: https://reviews.apache.org/r/41819/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 41819: Added ContainerConfig to all isolators.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/#review114234
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 281)
<https://reviews.apache.org/r/41819/#comment175045>
You can just do (no need to initailize it to None as that's the default behavior).
```
Option<string> user;
```
- Jie Yu
On Jan. 6, 2016, 11:41 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41819/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 11:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4240
> https://issues.apache.org/jira/browse/MESOS-4240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ContainerConfig to all isolators.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0
> src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760
> src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 3b95e195ad704f163c245175390d9a26bde7e17c
> src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 09952369c72d3c6322ae7a1c73cd68226d452ad2
> src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 2ddb9f4adbb879682cd39966ab974cf3fa32209c
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 4d82c2b2f231c59cbb600869a0f2b716c1e55f5e
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp a29f9d184a0d1088577b3168a12bc8c06493a477
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8af2cecdca947e55d8d39e26d2fc3d42212f36c3
> src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c3544aa313cbb185efb03bba59961cdf2b616a37
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
> src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 2e457015a0348a457581edf493877b71fab17090
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 361ed6561bd5e2f75d026922def01f42b43d61c2
> src/slave/containerizer/mesos/isolators/namespaces/pid.hpp c2d1455249618f9cd2e17dc2244b184d52b32eaf
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d65c1593b44f4b21237581147e57e441ebf3160d
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e3766c313a1bd2a838a73730c62c74c5ee8e1a4c
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 22a8428427b758bae4a0518356d7933c4110cd9f
> src/slave/containerizer/mesos/isolators/posix.hpp 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c
> src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d
>
> Diff: https://reviews.apache.org/r/41819/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>