You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/09/28 11:27:52 UTC

Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1814
    https://issues.apache.org/jira/browse/RANGER-1814


Repository: ranger


Description
-------

Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader usage - because it's not clear if that reader is closed properly. Suggested to move from instance variable to method local variable


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed 


Diff: https://reviews.apache.org/r/62659/diff/1/


Testing
-------

Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647


Thanks,

Zsombor Gegesy

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186667
-----------------------------------------------------------



Can you fix the whitespace errors in the patch?

- Colm O hEigeartaigh


On Sept. 28, 2017, 11:27 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62659/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 11:27 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1814
>     https://issues.apache.org/jira/browse/RANGER-1814
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader usage - because it's not clear if that reader is closed properly. Suggested to move from instance variable to method local variable
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed 
> 
> 
> Diff: https://reviews.apache.org/r/62659/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186584
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 28, 2017, 11:27 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62659/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 11:27 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1814
>     https://issues.apache.org/jira/browse/RANGER-1814
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader usage - because it's not clear if that reader is closed properly. Suggested to move from instance variable to method local variable
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed 
> 
> 
> Diff: https://reviews.apache.org/r/62659/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186832
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Oct. 2, 2017, 9:40 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62659/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 9:40 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1814
>     https://issues.apache.org/jira/browse/RANGER-1814
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader usage - because it's not clear if that reader is closed properly. Suggested to move from instance variable to method local variable
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed61 
> 
> 
> Diff: https://reviews.apache.org/r/62659/diff/2/
> 
> 
> Testing
> -------
> 
> Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/
-----------------------------------------------------------

(Updated Oct. 2, 2017, 9:40 a.m.)


Review request for ranger.


Changes
-------

Whitespace cleanup


Bugs: RANGER-1814
    https://issues.apache.org/jira/browse/RANGER-1814


Repository: ranger


Description
-------

Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader usage - because it's not clear if that reader is closed properly. Suggested to move from instance variable to method local variable


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed61 


Diff: https://reviews.apache.org/r/62659/diff/2/

Changes: https://reviews.apache.org/r/62659/diff/1-2/


Testing
-------

Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647


Thanks,

Zsombor Gegesy