[GitHub] [geode] jinmeiliao commented on a change in pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

[GitBox <gi...@apache.org>]

jinmeiliao commented on a change in pull request #7159:
URL: https://github.com/apache/geode/pull/7159#discussion_r761401680



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
##########
@@ -211,11 +211,17 @@ private PooledConnection createPooledConnection(ServerLocation serverLocation)
    */
   private PooledConnection forceCreateConnection(ServerLocation serverLocation)
       throws ServerRefusedConnectionException, ServerOperationException {
+    PooledConnection connection = null;
     connectionAccounting.create();
     try {
-      return createPooledConnection(serverLocation);
+      connection = createPooledConnection(serverLocation);
+      return connection;

Review comment:
       instead of the finally block, maybe add the `connectionAccounting.create()` line before the return?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org