You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/07/18 13:20:19 UTC

Re: svn commit: r1147594 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

On Sun, Jul 17, 2011 at 08:42,  <st...@apache.org> wrote:
>...
> +++ subversion/trunk/tools/dev/unix-build/Makefile.svn Sun Jul 17 12:42:40 2011
> @@ -1186,7 +1186,8 @@ $(SVN_OBJDIR)/.bindings-compiled: $(SVN_
>                LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make swig-rb
>        if [ $(ENABLE_PERL_BINDINGS) = yes ]; then \
>                cd $(svn_builddir) \
> -                       && make swig-pl; \
> +                       && env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
> +                               make swig-pl; \
>        fi

I don't think you want that backslash...

Cheers,
-g

Re: svn commit: r1147594 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

Posted by Stefan Sperling <st...@elego.de>.
On Mon, Jul 18, 2011 at 07:20:19AM -0400, Greg Stein wrote:
> On Sun, Jul 17, 2011 at 08:42,  <st...@apache.org> wrote:
> >...
> > +++ subversion/trunk/tools/dev/unix-build/Makefile.svn Sun Jul 17 12:42:40 2011
> > @@ -1186,7 +1186,8 @@ $(SVN_OBJDIR)/.bindings-compiled: $(SVN_
> >                LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make swig-rb
> >        if [ $(ENABLE_PERL_BINDINGS) = yes ]; then \
> >                cd $(svn_builddir) \
> > -                       && make swig-pl; \
> > +                       && env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
> > +                               make swig-pl; \
> >        fi
> 
> I don't think you want that backslash...

Make spawns a new subshell for each new line in a rule.

I need all the backslashes to prevent make from splitting the
if-statement across multiple shell invocations.
The whole if-statement needs to appear on a single line to the shell
including the terminating 'fi'.