[GitHub] [mynewt-core] mlaz commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove newtmgr and change OICMGR to use OMP

[GitBox <gi...@apache.org>]

mlaz commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove newtmgr and change OICMGR to use OMP 
URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r330784549
 
 

 ##########
 File path: sys/log/full/src/log_cbmem.c
 ##########
 @@ -70,27 +73,29 @@ log_cbmem_append_mbuf_body(struct log *log, const struct log_entry_hdr *hdr,
 {
     struct cbmem *cbmem;
     struct cbmem_scat_gath sg = {
-        .entries = (struct cbmem_scat_gath_entry[3]) {
+        .entries = (struct cbmem_scat_gath_entry[]) {
             {
                 .flat_buf = hdr,
                 .flat_len = LOG_BASE_ENTRY_HDR_SIZE,
             },
+#if MYNEWT_VAL(LOG_VERSION) > 2
             {
                 .flat_buf = hdr->ue_imghash,
                 .flat_len = 0,
             },
+#endif
             {
                 .om = om,
             },
         },
         .count = 3,
 
 Review comment:
   Did you mean count is only 2 if LOG_VERSION < 3 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services