You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2020/09/15 05:15:50 UTC

[zeppelin] branch branch-0.9 updated: [ZEPPELIN-5036]. zeppelin.interpreter.dep.mvnRepo doesn't take effect

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.9 by this push:
     new 515d09f  [ZEPPELIN-5036]. zeppelin.interpreter.dep.mvnRepo doesn't take effect
515d09f is described below

commit 515d09f38262408cfc8f7891abcf748262ce5057
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Sat Sep 12 16:50:41 2020 +0800

    [ZEPPELIN-5036]. zeppelin.interpreter.dep.mvnRepo doesn't take effect
    
    ### What is this PR for?
    
    Simple PR to fix the issue of `zeppelin.interpreter.dep.mvnRepo` doesn't take effect. Should use ZeppelinConfiguration instead of System.getProperty
    
    ### What type of PR is it?
    [Bug Fix ]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-5036
    
    ### How should this be tested?
    * Manually tested
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #3903 from zjffdu/ZEPPELIN-5036 and squashes the following commits:
    
    fd4f4fc3b [Jeff Zhang] [ZEPPELIN-5036]. zeppelin.interpreter.dep.mvnRepo doesn't take effect
    
    (cherry picked from commit 49ae3f6df9257c03f582f985f287b65bf2302993)
    Signed-off-by: Jeff Zhang <zj...@apache.org>
---
 .../src/main/java/org/apache/zeppelin/dep/Booter.java                 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java
index 3f0570a..24b8331 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java
@@ -19,6 +19,7 @@ package org.apache.zeppelin.dep;
 
 import org.apache.commons.lang3.Validate;
 import org.apache.maven.repository.internal.MavenRepositorySystemSession;
+import org.apache.zeppelin.conf.ZeppelinConfiguration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.sonatype.aether.RepositorySystem;
@@ -74,7 +75,8 @@ public class Booter {
   public static RemoteRepository newCentralRepository() {
     String mvnRepo = System.getenv("ZEPPELIN_INTERPRETER_DEP_MVNREPO");
     if (mvnRepo == null) {
-      mvnRepo = System.getProperty("zeppelin.interpreter.dep.mvnRepo");
+      mvnRepo = ZeppelinConfiguration.create().getString(
+              ZeppelinConfiguration.ConfVars.ZEPPELIN_INTERPRETER_DEP_MVNREPO);
     }
     if (mvnRepo == null) {
       mvnRepo = "https://repo1.maven.org/maven2/";