[GitHub] [submarine] pingsutw commented on a change in pull request #702: SUBMARINE-965. Users should not have the privilege to create experiments in different namespaces

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #702:
URL: https://github.com/apache/submarine/pull/702#discussion_r684969774



##########
File path: submarine-server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
##########
@@ -224,7 +222,6 @@ private void verifyResult(Experiment experiment, String uid) {
     assertEquals(experimentFinishedTime, experiment.getFinishedTime());
     assertEquals(metaName, experiment.getSpec().getMeta().getName());
     assertEquals(metaFramework, experiment.getSpec().getMeta().getFramework());
-    assertEquals(metaNamespace, experiment.getSpec().getMeta().getNamespace());

Review comment:
       I think we should assert that the experiment namespace is default. And we should add a new test to make sure the namespace is what we expect if we update `ENV_NAMESPACE`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org