You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/09/25 15:55:55 UTC
svn commit: r1893627 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
Author: tilman
Date: Sat Sep 25 15:55:55 2021
New Revision: 1893627
URL: http://svn.apache.org/viewvc?rev=1893627&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov; remove unneeded null check
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java?rev=1893627&r1=1893626&r2=1893627&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java Sat Sep 25 15:55:55 2021
@@ -331,6 +331,7 @@ public final class JPEGFactory
return pdImage;
}
+ // never returns null
private static ImageWriter getJPEGImageWriter() throws IOException
{
Iterator<ImageWriter> writers = ImageIO.getImageWritersBySuffix("jpeg");
@@ -374,8 +375,9 @@ public final class JPEGFactory
IIOMetadata data = imageWriter.getDefaultImageMetadata(imageTypeSpecifier, jpegParam);
Element tree = (Element)data.getAsTree("javax_imageio_jpeg_image_1.0");
Element jfif = (Element)tree.getElementsByTagName("app0JFIF").item(0);
- jfif.setAttribute("Xdensity", Integer.toString(dpi));
- jfif.setAttribute("Ydensity", Integer.toString(dpi));
+ String dpiString = Integer.toString(dpi);
+ jfif.setAttribute("Xdensity", dpiString);
+ jfif.setAttribute("Ydensity", dpiString);
jfif.setAttribute("resUnits", "1"); // 1 = dots/inch
// write
@@ -389,10 +391,7 @@ public final class JPEGFactory
{
ios.close();
}
- if (imageWriter != null)
- {
- imageWriter.dispose();
- }
+ imageWriter.dispose();
}
}