[GitHub] [superset] graceguo-supercat commented on pull request #15436: feat: add more SIP-40 errors to SQL Lab

[GitBox <gi...@apache.org>]

graceguo-supercat commented on pull request #15436:
URL: https://github.com/apache/superset/pull/15436#issuecomment-876692358


   Hi @betodealmeida this PR cause some issues in airbnb: when user hit permission deny error, they will see 
   <img width="782" alt="Screen Shot 2021-07-08 at 12 33 19 PM" src="https://user-images.githubusercontent.com/27990562/124980038-bd85c780-dfe8-11eb-83ac-5b7c1b7f436b.png">
   
   I will revert this PR from airbnb release branch. But it will cause conflict if reverting from master. Could you please take a look?
   
   cc @john-bodley 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org