[GitHub] [incubator-pagespeed-mod] gustavo-roganti opened a new issue #2066: CSS Minification - custom properties with value 0 followed by a unit is rewritten to 0 without a unit.

[GitBox <gi...@apache.org>]

gustavo-roganti opened a new issue #2066:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2066


   Linked to https://github.com/apache/incubator-pagespeed-mod/issues/1538
   
   A css custom property (see https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties) is defined as
   `--custom-offset: 0px`
   and is then used in a CSS rule
   `top: calc(50% + var(--custom-offset))`
   
   but mod_pagespeed (version  1.13.35.2-0) rewrites the variable removing the `px` as
   `--custom-offset:0`
   
   and the `calc()` rule breaks.
   
   
   
   The fix to bug 1538 checks if the css value is used in "calc(" but this does not work if the value is stored in a custom variable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-pagespeed-mod] gustavo-roganti commented on issue #2066: CSS Minification - custom properties with value 0 followed by a unit is rewritten to 0 without a unit.

[GitBox <gi...@apache.org>]

gustavo-roganti commented on issue #2066:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2066#issuecomment-826836896


   I'm sorry but I am not able to try in a newer version. I'm using a pre-made docker image (bitnami wordpress) with version 1.13.35.2-0 in it. I know too little to set up a testing environment with the latest version.
   
   If anyone else could check if `--custom-offset: 0px` gets converted to `--custom-offset: 0` on the latest versions, it would point to this bug still being present.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #2066: CSS Minification - custom properties with value 0 followed by a unit is rewritten to 0 without a unit.

[GitBox <gi...@apache.org>]

Lofesa commented on issue #2066:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2066#issuecomment-826725648


   Have you tried the latest version 1.14.36.1 or latest-beta?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org