You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2013/08/22 15:25:17 UTC
svn commit: r1516445 -
/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Author: ggregory
Date: Thu Aug 22 13:25:16 2013
New Revision: 1516445
URL: http://svn.apache.org/r1516445
Log:
Explicit boxing and use Long cache.
Modified:
logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1516445&r1=1516444&r2=1516445&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java (original)
+++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java Thu Aug 22 13:25:16 2013
@@ -131,7 +131,7 @@ public class SocketServer extends Abstra
// socket has been accepted.
final SocketHandler handler = new SocketHandler(clientSocket);
- handlers.put(handler.getId(), handler);
+ handlers.put(Long.valueOf(handler.getId()), handler);
handler.start();
} catch (final IOException ioe) {
System.out.println("Exception encountered on accept. Ignoring. Stack Trace :");
@@ -195,7 +195,7 @@ public class SocketServer extends Abstra
}
}
} finally {
- handlers.remove(getId());
+ handlers.remove(Long.valueOf(getId()));
}
}
}
Re: svn commit: r1516445 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Posted by Ralph Goers <ra...@dslextreme.com>.
Scott, Gary did two separate commits that were basically the same thing. Just ignore this thread.
Ralph
On Aug 22, 2013, at 9:20 AM, Scott Deboy wrote:
> Can you include that reply here? Too many mails flying by.
>
> Scott
>
> On Aug 22, 2013 9:16 AM, "Gary Gregory" <ga...@gmail.com> wrote:
> On Thu, Aug 22, 2013 at 12:09 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> Why?
>
> See my previous reply.
>
> Gary
>
>
> On Aug 22, 2013, at 6:25 AM, ggregory@apache.org wrote:
>
> > Author: ggregory
> > Date: Thu Aug 22 13:25:16 2013
> > New Revision: 1516445
> >
> > URL: http://svn.apache.org/r1516445
> > Log:
> > Explicit boxing and use Long cache.
> >
> > Modified:
> > logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> >
> > Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1516445&r1=1516444&r2=1516445&view=diff
> > ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java (original)
> > +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java Thu Aug 22 13:25:16 2013
> > @@ -131,7 +131,7 @@ public class SocketServer extends Abstra
> > // socket has been accepted.
> >
> > final SocketHandler handler = new SocketHandler(clientSocket);
> > - handlers.put(handler.getId(), handler);
> > + handlers.put(Long.valueOf(handler.getId()), handler);
> > handler.start();
> > } catch (final IOException ioe) {
> > System.out.println("Exception encountered on accept. Ignoring. Stack Trace :");
> > @@ -195,7 +195,7 @@ public class SocketServer extends Abstra
> > }
> > }
> > } finally {
> > - handlers.remove(getId());
> > + handlers.remove(Long.valueOf(getId()));
> > }
> > }
> > }
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1516445 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Posted by Scott Deboy <sc...@gmail.com>.
Can you include that reply here? Too many mails flying by.
Scott
On Aug 22, 2013 9:16 AM, "Gary Gregory" <ga...@gmail.com> wrote:
> On Thu, Aug 22, 2013 at 12:09 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> Why?
>>
>
> See my previous reply.
>
> Gary
>
>
>> On Aug 22, 2013, at 6:25 AM, ggregory@apache.org wrote:
>>
>> > Author: ggregory
>> > Date: Thu Aug 22 13:25:16 2013
>> > New Revision: 1516445
>> >
>> > URL: http://svn.apache.org/r1516445
>> > Log:
>> > Explicit boxing and use Long cache.
>> >
>> > Modified:
>> >
>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1516445&r1=1516444&r2=1516445&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
>> Thu Aug 22 13:25:16 2013
>> > @@ -131,7 +131,7 @@ public class SocketServer extends Abstra
>> > // socket has been accepted.
>> >
>> > final SocketHandler handler = new
>> SocketHandler(clientSocket);
>> > - handlers.put(handler.getId(), handler);
>> > + handlers.put(Long.valueOf(handler.getId()), handler);
>> > handler.start();
>> > } catch (final IOException ioe) {
>> > System.out.println("Exception encountered on accept.
>> Ignoring. Stack Trace :");
>> > @@ -195,7 +195,7 @@ public class SocketServer extends Abstra
>> > }
>> > }
>> > } finally {
>> > - handlers.remove(getId());
>> > + handlers.remove(Long.valueOf(getId()));
>> > }
>> > }
>> > }
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1516445 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 22, 2013 at 12:09 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> Why?
>
See my previous reply.
Gary
> On Aug 22, 2013, at 6:25 AM, ggregory@apache.org wrote:
>
> > Author: ggregory
> > Date: Thu Aug 22 13:25:16 2013
> > New Revision: 1516445
> >
> > URL: http://svn.apache.org/r1516445
> > Log:
> > Explicit boxing and use Long cache.
> >
> > Modified:
> >
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1516445&r1=1516444&r2=1516445&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> Thu Aug 22 13:25:16 2013
> > @@ -131,7 +131,7 @@ public class SocketServer extends Abstra
> > // socket has been accepted.
> >
> > final SocketHandler handler = new
> SocketHandler(clientSocket);
> > - handlers.put(handler.getId(), handler);
> > + handlers.put(Long.valueOf(handler.getId()), handler);
> > handler.start();
> > } catch (final IOException ioe) {
> > System.out.println("Exception encountered on accept.
> Ignoring. Stack Trace :");
> > @@ -195,7 +195,7 @@ public class SocketServer extends Abstra
> > }
> > }
> > } finally {
> > - handlers.remove(getId());
> > + handlers.remove(Long.valueOf(getId()));
> > }
> > }
> > }
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1516445 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Posted by Ralph Goers <ra...@dslextreme.com>.
Why?
On Aug 22, 2013, at 6:25 AM, ggregory@apache.org wrote:
> Author: ggregory
> Date: Thu Aug 22 13:25:16 2013
> New Revision: 1516445
>
> URL: http://svn.apache.org/r1516445
> Log:
> Explicit boxing and use Long cache.
>
> Modified:
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
>
> Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1516445&r1=1516444&r2=1516445&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java (original)
> +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java Thu Aug 22 13:25:16 2013
> @@ -131,7 +131,7 @@ public class SocketServer extends Abstra
> // socket has been accepted.
>
> final SocketHandler handler = new SocketHandler(clientSocket);
> - handlers.put(handler.getId(), handler);
> + handlers.put(Long.valueOf(handler.getId()), handler);
> handler.start();
> } catch (final IOException ioe) {
> System.out.println("Exception encountered on accept. Ignoring. Stack Trace :");
> @@ -195,7 +195,7 @@ public class SocketServer extends Abstra
> }
> }
> } finally {
> - handlers.remove(getId());
> + handlers.remove(Long.valueOf(getId()));
> }
> }
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org