You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by jameslafa <gi...@git.apache.org> on 2017/09/05 14:55:43 UTC

[GitHub] flink pull request #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup...

GitHub user jameslafa opened a pull request:

    https://github.com/apache/flink/pull/4648

    [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

    ## Problem
    There is a breaking change in the Checkstyle-IDEA plugin since version **8.1**. The Flink `checkstyle.xml` is working up to version **8.0**.
    
    ## Fix
    Changing the `checkstyle.xml` is a sensible topic so we decided to updated the documentation to stipulate that we have to use the **8.0** version instead of **8.1+**.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jameslafa/flink 7584-update-documentation-setup-ide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4648
    
----
commit 434e52089f65cfb4784e326b661ba80dfb1bb9a1
Author: James Lafa <ja...@data-artisans.com>
Date:   2017-09-05T14:49:46Z

    [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

----


---

[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

Posted by jameslafa <gi...@git.apache.org>.

Github user jameslafa commented on the issue:

    https://github.com/apache/flink/pull/4648
  
    Hum I don't know how I missed that bulletpoint... Sorry
    @aljoscha, any reason to use 6.19 instead of 8.0?


---

[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4648
  
    I think it's because 6.19 is also what our Maven setup uses and I'm not sure if there are breaking changes in between (at least 8.1 has breaking changes).


---

[GitHub] flink pull request #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup...

Posted by jameslafa <gi...@git.apache.org>.

Github user jameslafa closed the pull request at:

    https://github.com/apache/flink/pull/4648


---

[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

Posted by jameslafa <gi...@git.apache.org>.

Github user jameslafa commented on the issue:

    https://github.com/apache/flink/pull/4648
  
    As decided, we stay on 6.19. I drop the pull request.


---

[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4648
  
    The documentation already stated that the checkstyle version had to be set to 6.19. (Which i think @aljoscha investigated)


---