You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/05/08 05:37:09 UTC

[GitHub] [parquet-mr] lssatvik opened a new pull request #791: Parquet-1860: Add missing Builder support

lssatvik opened a new pull request #791:
URL: https://github.com/apache/parquet-mr/pull/791


   Added Builder support to build ProtoParquetWriter instances through Builder class
   
   ProtoParquetWriter only has basic constructors, that which call deprecated super constructors. We cannot set many other options (Write mode, encoding etc) as well. 
   
   Extended the ParquetWriter.Builder class for builder support similar to as in AvroParquetWriter
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: 
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko commented on pull request #791: Parquet-1860: Add missing Builder Class to ProtoParquetWriter Class

Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #791:
URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-626122482


   Would be great if you could create a test under https://github.com/forcedotcom/incubator-parquet-mr/tree/master/parquet-protobuf/src/test/java/parquet/proto


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] lssatvik commented on pull request #791: Parquet-1860: Add missing Builder Class to ProtoParquetWriter Class

Posted by GitBox <gi...@apache.org>.
lssatvik commented on pull request #791:
URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-626145884


   > Would be great if you could create a test under https://github.com/forcedotcom/incubator-parquet-mr/tree/master/parquet-protobuf/src/test/java/parquet/proto
   
   Is there any format to create a test? I don't see a class with main function in the link you provided. If you could give me a link to the testing process, so that I know all about testing for this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko merged pull request #791: Parquet-1860: Add missing Builder Class to ProtoParquetWriter Class

Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #791:
URL: https://github.com/apache/parquet-mr/pull/791


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] lssatvik commented on pull request #791: Parquet-1860: Add missing Builder support to ProtoParquetWriter

Posted by GitBox <gi...@apache.org>.
lssatvik commented on pull request #791:
URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-625641517


   Where do I create a test? I have tested on my system, but I haven't "created" a test in the repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org