You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/17 07:00:27 UTC
Review Request 32153: SQOOP-1738 Sqoop2: HDFS Connector : Check for
output directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32153/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1738
https://issues.apache.org/jira/browse/SQOOP-1738
Repository: sqoop-sqoop2
Description
-------
I've added checks to ensure that output directory either don't exists or is empty. Otherwise the job will fail on submission.
Diffs
-----
common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java 8514541
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java ad500c2
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32153/diff/
Testing
-------
Added unit and integration tests.
Thanks,
Jarek Cecho
Re: Review Request 32153: SQOOP-1738 Sqoop2: HDFS Connector : Check
for output directory
Posted by Jarek Cecho <ja...@apache.org>.
> On March 17, 2015, 7:29 p.m., Abraham Elmahrek wrote:
> > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java, line 55
> > <https://reviews.apache.org/r/32153/diff/1/?file=897598#file897598line55>
> >
> > +1: MasterOfOrion?
Nice catch! For some reason I've miss remembered this one. I'll fix that shortly.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32153/#review76779
-----------------------------------------------------------
On March 17, 2015, 6 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32153/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 6 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1738
> https://issues.apache.org/jira/browse/SQOOP-1738
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added checks to ensure that output directory either don't exists or is empty. Otherwise the job will fail on submission.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java 8514541
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java ad500c2
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32153/diff/
>
>
> Testing
> -------
>
> Added unit and integration tests.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32153: SQOOP-1738 Sqoop2: HDFS Connector : Check
for output directory
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32153/#review76779
-----------------------------------------------------------
Ship it!
Nice!
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java
<https://reviews.apache.org/r/32153/#comment124447>
+1: MasterOfOrion?
- Abraham Elmahrek
On March 17, 2015, 6 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32153/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 6 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1738
> https://issues.apache.org/jira/browse/SQOOP-1738
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added checks to ensure that output directory either don't exists or is empty. Otherwise the job will fail on submission.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java 8514541
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java ad500c2
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32153/diff/
>
>
> Testing
> -------
>
> Added unit and integration tests.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32153: SQOOP-1738 Sqoop2: HDFS Connector : Check
for output directory
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32153/
-----------------------------------------------------------
(Updated March 17, 2015, 7:37 p.m.)
Review request for Sqoop.
Changes
-------
Fixing few typos.
Bugs: SQOOP-1738
https://issues.apache.org/jira/browse/SQOOP-1738
Repository: sqoop-sqoop2
Description
-------
I've added checks to ensure that output directory either don't exists or is empty. Otherwise the job will fail on submission.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java 8514541
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java ad500c2
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32153/diff/
Testing
-------
Added unit and integration tests.
Thanks,
Jarek Cecho