[GitHub] [superset] zhaoyongjie commented on a change in pull request #15568: refactor: icon to icons for controls

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #15568:
URL: https://github.com/apache/superset/pull/15568#discussion_r665856636



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
##########
@@ -190,7 +195,7 @@ class DatasourceControl extends React.PureComponent {
     return (
       <Styles data-test="datasource-control" className="DatasourceControl">
         <div className="data-container">
-          <Icon name="dataset-physical" className="dataset-svg" />
+          <Icons.DatasetPhysical className="dataset-svg" />

Review comment:
       conditional render `DatasetPhysical` or `DatasetVirtual` from `props.datasource.is_sqllab_view`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org