You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/15 14:11:10 UTC

[GitHub] [iotdb] zyk990424 commented on pull request #4581: [IOTDB-2153][IOTDB-2157] fix wildcard issues

zyk990424 commented on pull request #4581:
URL: https://github.com/apache/iotdb/pull/4581#issuecomment-994827517


   > @zyk990424 Please have a look at this PR. Thanks!
   > 
   > I decided to remove `PartialPath#alterPrefixPath` for 2 reasons:
   > 
   > 1. the meaning of the method is not clear
   > 2. returning multiple possible results means the caller need to query (or delete) each of the returned path, which is a waste of time.
   
   If you decide to remove this method, there should be a method that satisfy the requirements of the scenarios.  
   This method currently is mainly used for dividing logic path set, represented by the given path pattern, into several buckets identified by storage group. 
   Maybe using both the origin path pattern and the prefix path as parameters to filter series is fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org