You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/22 07:05:03 UTC

[GitHub] [rocketmq] rushsky518 opened a new pull request #1785: #1784 DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful

rushsky518 opened a new pull request #1785: #1784 DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful
URL: https://github.com/apache/rocketmq/pull/1785
 
 
   DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully
URL: https://github.com/apache/rocketmq/pull/1785#issuecomment-589928297
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29605092/badge)](https://coveralls.io/builds/29605092)
   
   Coverage decreased (-0.01%) to 50.852% when pulling **f4f70c6653bbb9df34a72d1c90e542f99b6fea4f on rushsky518:async_producer_shutdown** into **c233f65a0c1207d1d4ec94121e0024084ee82c6a on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully
URL: https://github.com/apache/rocketmq/pull/1785#issuecomment-589928297
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29677229/badge)](https://coveralls.io/builds/29677229)
   
   Coverage increased (+0.03%) to 50.898% when pulling **f2e70476ff233551e2fbb0ac10e6550da2e0e086 on rushsky518:async_producer_shutdown** into **c233f65a0c1207d1d4ec94121e0024084ee82c6a on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] rushsky518 commented on a change in pull request #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully

Posted by GitBox <gi...@apache.org>.
rushsky518 commented on a change in pull request #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully
URL: https://github.com/apache/rocketmq/pull/1785#discussion_r397801459
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
 ##########
 @@ -253,8 +254,10 @@ public void shutdown(final boolean shutdownFactory) {
             case CREATE_JUST:
                 break;
             case RUNNING:
-                this.mQClientFactory.unregisterProducer(this.defaultMQProducer.getProducerGroup());
                 this.defaultAsyncSenderExecutor.shutdown();
+                ThreadUtils.shutdownGracefully(this.defaultAsyncSenderExecutor,
 
 Review comment:
   Sorry, forgot to rm this line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] xiangwangcheng commented on a change in pull request #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully

Posted by GitBox <gi...@apache.org>.
xiangwangcheng commented on a change in pull request #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully
URL: https://github.com/apache/rocketmq/pull/1785#discussion_r397724593
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
 ##########
 @@ -253,8 +254,10 @@ public void shutdown(final boolean shutdownFactory) {
             case CREATE_JUST:
                 break;
             case RUNNING:
-                this.mQClientFactory.unregisterProducer(this.defaultMQProducer.getProducerGroup());
                 this.defaultAsyncSenderExecutor.shutdown();
+                ThreadUtils.shutdownGracefully(this.defaultAsyncSenderExecutor,
 
 Review comment:
   Why still invoke  `this.defaultAsyncSenderExecutor.shutdown();` while you already using  `ThreadUtils.shutdownGracefully`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful
URL: https://github.com/apache/rocketmq/pull/1785#issuecomment-589928297
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28900557/badge)](https://coveralls.io/builds/28900557)
   
   Coverage decreased (-0.05%) to 50.949% when pulling **61103e609fec0a110900428261863c8bba163c7f on rushsky518:async_producer_shutdown** into **35c38888e0d5678fb4aaad5ba8534b7552d9a9a0 on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls commented on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1785: DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown graceful
URL: https://github.com/apache/rocketmq/pull/1785#issuecomment-589928297
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28893401/badge)](https://coveralls.io/builds/28893401)
   
   Coverage decreased (-0.1%) to 50.893% when pulling **57c23315ae1f58d96655061651a24983b2049d35 on rushsky518:async_producer_shutdown** into **35c38888e0d5678fb4aaad5ba8534b7552d9a9a0 on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services