You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/23 08:04:23 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #6159: ui: Remove misleading links for users

davidjumani opened a new pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159


   ### Description
   
   Removes <a> tags which can appear as links and mislead users
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   ### Screenshots (if appropriate):
   
   ![Screenshot from 2022-03-23 13-31-22](https://user-images.githubusercontent.com/8244774/159651615-388c1964-9d31-4642-bec1-42c3ae458bf1.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1076291956


   @davidjumani can you please fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6159: ui: Remove misleading links for users

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1076055548


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1077043627


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1076060360


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6159 (SL-JID-1290)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1077044500


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6159: ui: Remove misleading links for users

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1076056377


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1077340753


   Code LGTM - pl run some manual tests before merging cc @nvazquez and 4.17 team


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6159: ui: Remove misleading anchor tags for users

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6159:
URL: https://github.com/apache/cloudstack/pull/6159#issuecomment-1077046795


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6159 (SL-JID-1294)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org