You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/02/16 03:10:47 UTC

[GitHub] [dubbo] codecov-io commented on issue #5746: some code optimization

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=h1) Report
> Merging [#5746](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/b288ad7e3812d2354e54aa2f20f8127f24586a5e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `33.33%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5746/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5746      +/-   ##
============================================
- Coverage     61.24%   61.22%   -0.03%     
- Complexity      422      495      +73     
============================================
  Files           922      928       +6     
  Lines         37498    37899     +401     
  Branches       5431     5447      +16     
============================================
+ Hits          22967    23204     +237     
- Misses        12055    12176     +121     
- Partials       2476     2519      +43
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `61.53% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `88.57% <100%> (ø)` | `16 <0> (ø)` | :arrow_down: |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...t/annotation/DubboLifecycleComponentRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvTGlmZWN5Y2xlQ29tcG9uZW50UmVnaXN0cmFyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/rpc/cluster/support/ForkingCluster.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../context/properties/AbstractDubboConfigBinder.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0Fic3RyYWN0RHViYm9Db25maWdCaW5kZXIuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | |
| [...ring/context/config/DubboConfigBeanCustomizer.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9jb25maWcvRHViYm9Db25maWdCZWFuQ3VzdG9taXplci5qYXZh) | `0% <0%> (-66.67%)` | `0% <0%> (ø)` | |
| [...che/dubbo/rpc/cluster/support/FailfastCluster.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsZmFzdENsdXN0ZXIuamF2YQ==) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...va/org/apache/dubbo/remoting/TimeoutException.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9UaW1lb3V0RXhjZXB0aW9uLmphdmE=) | `0% <0%> (-22.23%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `71.96% <0%> (-14.53%)` | `0% <0%> (ø)` | |
| ... and [120 more](https://codecov.io/gh/apache/dubbo/pull/5746/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=footer). Last update [b288ad7...b110fa4](https://codecov.io/gh/apache/dubbo/pull/5746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5746 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org