You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Matt Sicker (JIRA)" <ji...@apache.org> on 2016/07/29 00:31:20 UTC

[jira] [Commented] (DBCP-436) Avoid executing ROLLBACK when transaction is not active

    [ https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398498#comment-15398498 ] 

Matt Sicker commented on DBCP-436:
----------------------------------

I updated the fix version to 2.3, but it looks like you guys wanna close this.

> Avoid executing ROLLBACK when transaction is not active
> -------------------------------------------------------
>
>                 Key: DBCP-436
>                 URL: https://issues.apache.org/jira/browse/DBCP-436
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: Michael Mikhulya
>              Labels: performance
>             Fix For: 2.3
>
>
> {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on the connection as it is returned to the pool.
> It hurts performance.
> I suggest to don't call {{rollback}} if transaction is not active.
> Such improvement is done in HikariCP:
> https://github.com/brettwooldridge/HikariCP/issues/177



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)