You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 12:43:21 UTC

[GitHub] [superset] radhakvnr opened a new issue, #20827: Label colors are not working properly for Mixed Time Series Chart from 1.5

radhakvnr opened a new issue, #20827:
URL: https://github.com/apache/superset/issues/20827

   After upgrading to 1.5 from 1.3.2 we have noted that, the Label colors which we define at JSON Metadata of Dashboard is not having any affect. Only the first metric is getting the label color where as other metrics are falling back to the color schemes
   
   #### How to reproduce the bug
   
   1. Create a Mixed time Series chart
   2. Add that to a Dashboard and choose a color scheme
   3. Apply the Label colors for two metrics
   4. you can see only the first metric gets affected where as second metric is having default color.
   
   ### Expected results
   It should display the colors based on label colors what we defined at Dashboard JSON
   
   ### Actual results
   
   Only the first metric gets the color from Json Label where as second metric is having default color.
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   
   ### Environment
   
   (please complete the following information):
   
   - Chrome 103:
   - superset version: `1.5`
   - python version: `python --version`
   - node.js version: `node -v`
   - any feature flags active:
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ianr21 commented on issue #20827: Label colors are not working properly for Mixed Time Series Chart from 1.5

Posted by "ianr21 (via GitHub)" <gi...@apache.org>.
ianr21 commented on issue #20827:
URL: https://github.com/apache/superset/issues/20827#issuecomment-1575321297

   It works! Thank you for posting this!
   
   Any idea how to fix this if we have two metrics on the secondary Y-Axis?
   
   I tried these combinations, but can't change the color of the last metric.
   
   `
   "label_colors": { "MetricOne": "gray", "MetricTwo (1)": "red", "MetricThree (1)": "blue" }
   "label_colors": { "MetricOne": "gray", "MetricTwo (1)": "red", "MetricThree (2)": "blue" }
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Label colors are not working properly for Mixed Time Series Chart from 1.5 [superset]

Posted by "BrianWakhutu (via GitHub)" <gi...@apache.org>.
BrianWakhutu commented on issue #20827:
URL: https://github.com/apache/superset/issues/20827#issuecomment-2706204820

   > For mixed time series charts, you have to add "(1)" to the labels of the second metric to make it work: `"label_colors": { "MyLabel (1)": "red" }`
   
   Thanks for this ... It worked like mirth!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] andnig commented on issue #20827: Label colors are not working properly for Mixed Time Series Chart from 1.5

Posted by "andnig (via GitHub)" <gi...@apache.org>.
andnig commented on issue #20827:
URL: https://github.com/apache/superset/issues/20827#issuecomment-1438225326

   Can confirm this behavior with superset 2.0 (current master)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Label colors are not working properly for Mixed Time Series Chart from 1.5 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20827:
URL: https://github.com/apache/superset/issues/20827#issuecomment-1979894786

   [This PR](https://github.com/apache/superset/pull/27403) addresses the issue with the color label suffixes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Label colors are not working properly for Mixed Time Series Chart from 1.5 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #20827: Label colors are not working properly for Mixed Time Series Chart from 1.5
URL: https://github.com/apache/superset/issues/20827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Phonom commented on issue #20827: Label colors are not working properly for Mixed Time Series Chart from 1.5

Posted by "Phonom (via GitHub)" <gi...@apache.org>.
Phonom commented on issue #20827:
URL: https://github.com/apache/superset/issues/20827#issuecomment-1467725180

   For mixed time series charts, you have to add "(1)" to the labels of the second metrics to make it work:
   `
   "label_colors": {
   "MyLabel (1)": "red"
   }
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org