[jira] [Commented] (CASSANDRA-18661) Update cassandra-stress to use Apache Commons CLI

["Claude Warren (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-18661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823670#comment-17823670 ] 

Claude Warren commented on CASSANDRA-18661:
-------------------------------------------

[~bschoeni]

I have managed to get Stress to use the commons-cli code (after adding some more functionality to commons-cli).  So we will have to wait for commons-cli 1.7.0 to be  released.

However, there is a requirement in the code for the StressSettings to be serializable.  Is this an old Thrift requirement and can it be removed?  As I recall serialization is fraught with security issues, though this is only a test tool.  I just don't see how it would be used in the tool.  Any suggestions?

> Update cassandra-stress to use Apache Commons CLI
> -------------------------------------------------
>
>                 Key: CASSANDRA-18661
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18661
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/stress
>            Reporter: Brad Schoening
>            Assignee: Claude Warren
>            Priority: Normal
>              Labels: lhf
>
> The Apache Commons CLI library provides an API for parsing command line options with the package org.apache.commons.cli and this is already used by a dozen of existing Cassandra utilities including:
> {quote}SSTableMetadataViewer, StandaloneScrubber, StandaloneSplitter, SSTableExport, BulkLoader, and others.
> {quote}
> However, cassandra-stress is an outlier which uses its own custom classes to parse command line options with classes such as OptionsSimple.  In addition, the options syntax for username, password, and others are not aligned with the format used by CQLSH.
> Currently, there are > 5K lines of code in 'settings' which appears to just process command line args.
> This suggestion is to:
>  
> a) Upgrade cassandra-stress to use Apache Commons CLI (no new dependencies are required as this library is already used by the project)
>  
> b) Align the cassandra-stress CLI options with those in CQLSH, 
>  
> {quote}For example, using the new syntax like CQLSH:
> {quote}
>  
> cassandra-stress -username foo -password bar
> {quote}and replacing the old syntax:
> {quote}
> cassandra-stress -mode username=foo and password=bar
>  
> This will simplify and unify the code base, eliminate code and reduce the confusion between similar named classes such as org.apache.cassandra.stress.settings.\{Option, OptionsMulti, OptionsSimple} and org.apache.commons.cli.{Option, OptionGroup, Options)
>  
> Note: documentation will need to be updated as well



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org