You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "clownxc (via GitHub)" <gi...@apache.org> on 2023/05/10 15:49:49 UTC

[GitHub] [flink] clownxc commented on a diff in pull request #22555: [FLINK-31706] [runtime] The default source parallelism should be the same as ex…

clownxc commented on code in PR #22555:
URL: https://github.com/apache/flink/pull/22555#discussion_r1190107593


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java:
##########
@@ -546,7 +553,7 @@ static DefaultVertexParallelismAndInputInfosDecider from(
                 configuration.get(
                         BatchExecutionOptions.ADAPTIVE_AUTO_PARALLELISM_AVG_DATA_VOLUME_PER_TASK),
                 configuration.get(
-                        BatchExecutionOptions
-                                .ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM));
+                        BatchExecutionOptions.ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM),
+                configuration.get(CoreOptions.DEFAULT_PARALLELISM));
     }

Review Comment:
   > parallelism.default should be obtained from ExecutionConfig instead of jobmaster Configuration
   
   Sorry for my mistake, I changed the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org