You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Bogdanov Andrey <ba...@mail.ru> on 2014/06/27 20:42:13 UTC
Re[4]: Help on WB
Hi Maxim,
I've just push changes to the repository https://github.com/bay73/whiteboard.git
Now linkWebSocket method accepts two additional parameter: bufferSize and bufferTimeout
bufferSize parameter shows the size of buffer in bytes before posting changes
bufferTimeout shows the timeout (in milliseconds) - in this case changes will be posted even if size limit is not exceeded.
So now you can call the method like this:
whiteboard.linkWebSocket(url, 10000, 500);
This parameters also can be set in runtime. For example:
whiteboard.properties.ws.bufferSize = 20000
whiteboard.properties.ws.bufferTimeout = 1000
Best regards,
Andrey Bogdanov
Wed, 25 Jun 2014 13:49:34 +0700 от Maxim Solodovnik <so...@gmail.com>:
>Thanks a lot,
>
>There is no rush :) I believe this module will be heavily modified for our needs :)
>
>
>On 25 June 2014 01:44, Bogdanov Andrey < bay73@mail.ru > wrote:
>>Hi Maxim,
>>
>>Sorry for a delay - I'm in a trip and can't read mails every day.
>>
>>Yes, I think this modifcation is possible. There can be some buffer which collect changes before posting them. And it will post chunks after either time limit or size limit (for example 1 second or 50 points). I will try to make this modifications in a week.
>>
>>Regards,
>>Andrey
>>
>>
>>Mon, 23 Jun 2014 14:19:46 +0700 от Maxim Solodovnik < solomax666@gmail.com >:
>>
>>>I would like to add configurable parameter to js library to be able to send points by chunks i.e.
>>>currently if free drawing is used every point is sent separately, I would like parameter to be able to send 50 or 100 points at once
>>>is it possible?
>>>
>>>
>>>On 23 June 2014 00:02, Bogdanov Andrey < bay73@mail.ru > wrote:
>>>>Hi Maxim,
>>>>
>>>>Of course you can, I will glad to help.
>>>>
>>>>Regards,
>>>>Andrey
>>>>
>>>>
>>>>Sun, 22 Jun 2014 00:58:18 +0700 от Maxim Solodovnik < solomax666@gmail.com >:
>>>>
>>>>>Hello Andrey,
>>>>>
>>>>>I have started to integrate your WB into OM and I would like to get some help :)
>>>>>Is it OK to send you some code modification requests?
>>>>>
>>>>>Thanks in advance
>>>>>
>>>>>--
>>>>>WBR
>>>>>Maxim aka solomax
>>>
>>>
>>>
>>>--
>>>WBR
>>>Maxim aka solomax
>
>
>
>--
>WBR
>Maxim aka solomax
Re: Re[6]: Help on WB
Posted by Maxim Solodovnik <so...@gmail.com>.
Finally was able to merge!
Thanks!
Hopefully can continue testing/fixing this module :)
On 29 June 2014 17:54, Maxim Solodovnik <so...@gmail.com> wrote:
> Great, thanks!
> will merge it asap :)
>
>
> On 29 June 2014 17:47, Bogdanov Andrey <ba...@mail.ru> wrote:
>
>> It will not cut commands while sending. The parameter only limits chunk
>> size but all commands there will be sended as a whole.
>>
>>
>> Sun, 29 Jun 2014 16:52:26 +0700 от Maxim Solodovnik <solomax666@gmail.com
>> >:
>> >
>> > Hello Andrey,
>> >
>> > Thanks for the quick fix :)
>> > I have only one question: Is it safe to set buffer in bytes?
>> > Is it possible command being send will be truncated?
>> >
>> >
>> > On 28 June 2014 01:42, Bogdanov Andrey < bay73@mail.ru > wrote:
>> > >Hi Maxim,
>> > >
>> > >I've just push changes to the repository
>> https://github.com/bay73/whiteboard.git
>> > >Now linkWebSocket method accepts two additional parameter: bufferSize
>> and bufferTimeout
>> > >
>> > >bufferSize parameter shows the size of buffer in bytes before
>> posting changes
>> > >bufferTimeout shows the timeout (in milliseconds) - in this case
>> changes will be posted even if size limit is not exceeded.
>> > >
>> > >So now you can call the method like this:
>> > >whiteboard.linkWebSocket(url, 10000, 500);
>> > >
>> > >This parameters also can be set in runtime. For example:
>> > >whiteboard.properties.ws.bufferSize = 20000
>> > >whiteboard.properties.ws.bufferTimeout = 1000
>> > >
>> > >
>> > >Best regards,
>> > >Andrey Bogdanov
>> > >
>>
>
>
>
> --
> WBR
> Maxim aka solomax
>
--
WBR
Maxim aka solomax
Re: Re[6]: Help on WB
Posted by Maxim Solodovnik <so...@gmail.com>.
Great, thanks!
will merge it asap :)
On 29 June 2014 17:47, Bogdanov Andrey <ba...@mail.ru> wrote:
> It will not cut commands while sending. The parameter only limits chunk
> size but all commands there will be sended as a whole.
>
>
> Sun, 29 Jun 2014 16:52:26 +0700 от Maxim Solodovnik <solomax666@gmail.com
> >:
> >
> > Hello Andrey,
> >
> > Thanks for the quick fix :)
> > I have only one question: Is it safe to set buffer in bytes?
> > Is it possible command being send will be truncated?
> >
> >
> > On 28 June 2014 01:42, Bogdanov Andrey < bay73@mail.ru > wrote:
> > >Hi Maxim,
> > >
> > >I've just push changes to the repository
> https://github.com/bay73/whiteboard.git
> > >Now linkWebSocket method accepts two additional parameter: bufferSize
> and bufferTimeout
> > >
> > >bufferSize parameter shows the size of buffer in bytes before
> posting changes
> > >bufferTimeout shows the timeout (in milliseconds) - in this case
> changes will be posted even if size limit is not exceeded.
> > >
> > >So now you can call the method like this:
> > >whiteboard.linkWebSocket(url, 10000, 500);
> > >
> > >This parameters also can be set in runtime. For example:
> > >whiteboard.properties.ws.bufferSize = 20000
> > >whiteboard.properties.ws.bufferTimeout = 1000
> > >
> > >
> > >Best regards,
> > >Andrey Bogdanov
> > >
>
--
WBR
Maxim aka solomax
Re[6]: Help on WB
Posted by Bogdanov Andrey <ba...@mail.ru>.
It will not cut commands while sending. The parameter only limits chunk size but all commands there will be sended as a whole.
Sun, 29 Jun 2014 16:52:26 +0700 от Maxim Solodovnik <so...@gmail.com>:
>
> Hello Andrey,
>
> Thanks for the quick fix :)
> I have only one question: Is it safe to set buffer in bytes?
> Is it possible command being send will be truncated?
>
>
> On 28 June 2014 01:42, Bogdanov Andrey < bay73@mail.ru > wrote:
> >Hi Maxim,
> >
> >I've just push changes to the repository https://github.com/bay73/whiteboard.git
> >Now linkWebSocket method accepts two additional parameter: bufferSize and bufferTimeout
> >
> >bufferSize parameter shows the size of buffer in bytes before posting changes
> >bufferTimeout shows the timeout (in milliseconds) - in this case changes will be posted even if size limit is not exceeded.
> >
> >So now you can call the method like this:
> >whiteboard.linkWebSocket(url, 10000, 500);
> >
> >This parameters also can be set in runtime. For example:
> >whiteboard.properties.ws.bufferSize = 20000
> >whiteboard.properties.ws.bufferTimeout = 1000
> >
> >
> >Best regards,
> >Andrey Bogdanov
> >
Re: Re[4]: Help on WB
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Andrey,
Thanks for the quick fix :)
I have only one question: Is it safe to set buffer in bytes?
Is it possible command being send will be truncated?
On 28 June 2014 01:42, Bogdanov Andrey <ba...@mail.ru> wrote:
> Hi Maxim,
>
> I've just push changes to the repository
> https://github.com/bay73/whiteboard.git
> Now linkWebSocket method accepts two additional parameter: bufferSize and
> bufferTimeout
>
> bufferSize parameter shows the size of buffer in bytes before
> posting changes
> bufferTimeout shows the timeout (in milliseconds) - in this case changes
> will be posted even if size limit is not exceeded.
>
> So now you can call the method like this:
> whiteboard.linkWebSocket(url, 10000, 500);
>
> This parameters also can be set in runtime. For example:
> whiteboard.properties.ws.bufferSize = 20000
> whiteboard.properties.ws.bufferTimeout = 1000
>
>
> Best regards,
> Andrey Bogdanov
>
> Wed, 25 Jun 2014 13:49:34 +0700 от Maxim Solodovnik <solomax666@gmail.com
> >:
>
> Thanks a lot,
>
> There is no rush :) I believe this module will be heavily modified for our
> needs :)
>
>
> On 25 June 2014 01:44, Bogdanov Andrey <bay73@mail.ru
> <ht...@mail.ru>> wrote:
>
> Hi Maxim,
>
> Sorry for a delay - I'm in a trip and can't read mails every day.
>
> Yes, I think this modifcation is possible. There can be some buffer which
> collect changes before posting them. And it will post chunks after either
> time limit or size limit (for example 1 second or 50 points). I will try to
> make this modifications in a week.
>
> Regards,
> Andrey
>
>
> Mon, 23 Jun 2014 14:19:46 +0700 от Maxim Solodovnik <solomax666@gmail.com
> <ht...@gmail.com>>:
>
> I would like to add configurable parameter to js library to be able to
> send points by chunks i.e.
> currently if free drawing is used every point is sent separately, I would
> like parameter to be able to send 50 or 100 points at once
> is it possible?
>
>
> On 23 June 2014 00:02, Bogdanov Andrey <bay73@mail.ru
> <ht...@mail.ru>> wrote:
>
> Hi Maxim,
>
> Of course you can, I will glad to help.
>
> Regards,
> Andrey
>
>
> Sun, 22 Jun 2014 00:58:18 +0700 от Maxim Solodovnik <solomax666@gmail.com
> <ht...@gmail.com>>:
>
> Hello Andrey,
>
> I have started to integrate your WB into OM and I would like to get some
> help :)
> Is it OK to send you some code modification requests?
>
> Thanks in advance
>
> --
> WBR
> Maxim aka solomax
>
>
>
>
>
> --
> WBR
> Maxim aka solomax
>
>
>
>
>
> --
> WBR
> Maxim aka solomax
>
>
>
--
WBR
Maxim aka solomax