You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/13 18:29:41 UTC

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8694: [dashboard] feat: REST API

willbarrett commented on a change in pull request #8694: [dashboard] feat: REST API
URL: https://github.com/apache/incubator-superset/pull/8694#discussion_r356274274
 
 

 ##########
 File path: superset/views/api.py
 ##########
 @@ -27,6 +27,8 @@
 from superset.utils import core as utils
 
 from .base import api, BaseSupersetView, handle_api_exception
+from .dashboard import api as dashboard_api  # pylint: disable=all
+from .database import api as database_api  # pylint: disable=all
 
 Review comment:
   I think it would be preferable to disable only the pylint rules violated rather than all pylint rules for the line. It serves as documentation of what Pylint is complaining about going forward.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org