You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by machard <gi...@git.apache.org> on 2014/08/06 10:41:16 UTC

[GitHub] cordova-plugin-inappbrowser pull request: firefoxos inappbrowser _...

GitHub user machard opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/58

    firefoxos inappbrowser _blank target position is fixed

    Hi,
    
    i changed the position of the browserwrap element to fixed so that it works even when the inappbrowser is opened when the page is scrolled

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/machard/cordova-plugin-inappbrowser fixed_position

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 97e0eac60366fcf22055e7bd23f5bfffe76b7b87
Author: Tracktl <tr...@macbook-pro-de-tracktl.local>
Date:   2014-08-05T13:53:45Z

    inappbrowser _blank target position is fixed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: firefoxos inappbrowser _...

Posted by rodms10 <gi...@git.apache.org>.

Github user rodms10 commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/58#issuecomment-51946902
  
    Thanks for the fix! @zalun should take a look. (may take some time, he's on vacation).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: firefoxos inappbrowser _...

Posted by zalun <gi...@git.apache.org>.

Github user zalun commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/58#issuecomment-53408390
  
    Looks good! - merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: firefoxos inappbrowser _...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/58


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---